Project overhaul with recent dependencies & code quality#112
Open
QuentiumYT wants to merge 11 commits intoINESCTEC:masterfrom
Open
Project overhaul with recent dependencies & code quality#112QuentiumYT wants to merge 11 commits intoINESCTEC:masterfrom
QuentiumYT wants to merge 11 commits intoINESCTEC:masterfrom
Conversation
Fix dependency vulnerabilities & security warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, here is the PR I propose to maintain this project and keep a code convention using ruff. It also includes numerous improvements & bug fixes around the project.
I recommend reviewing commit by commit to understand exactly what I did, because I formatted the code initially with ruff with defaut settings to have a classic code convention.
GitHub Actions were also updated to provide recent releases and features.
Python standard types & format imports were used instead of old typing library (because Python >= 3.10 support this typing (Python 3.9 added that))
Did some linting with ruff and a few other personal improvements
Dependencies in the uv.lock file are bumped to latest, it has been tested with unit tests
.python-version is not forced, allowing the project to embrace Python 3.14 development if needed (that's what I've did)
Added a package.json for easier dependencies management (complementary to fix CVE)
Removed trailing spaces in LICENSE
Huge rework of docs-site for latest npm versions, latest next and fumadocs. It also fix the missing icon that was initially wanted
Prevent hydration warnings of p tags with recent NextJS (text in div tags are already converted to p tags)
Prevent tag issues with non leading v in create release workflow (see here for example)
Last question remains, is package.json & package-lock.json needed in the root directory?