Dagster Reprocessing#1384
Merged
bryan-harter merged 6 commits intoMay 27, 2026
Merged
Conversation
tech3371
approved these changes
May 27, 2026
Contributor
tech3371
left a comment
tech3371
left a comment
There was a problem hiding this comment.
Looks great! flows nicely!
| else: | ||
| # If data_level is provided (and therefore descriptor) construct the | ||
| # asset name using the input parameters | ||
| asset_name = f"{instrument}_{data_level}_{descriptor}" |
Contributor
There was a problem hiding this comment.
Bryan had issue with assets name with - and descriptor has -. Just FYI.
Contributor
There was a problem hiding this comment.
I don't know the specific but really easy to follow!
Member
|
Looks good to me! I'm just going to go ahead and merge it for now! |
bryan-harter
merged commit 2726a3e
into
IMAP-Science-Operations-Center:dagster
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
# Change Summary
Overview
File changes
Testing