Skip to content

Release lambda handler logics#1383

Open
tech3371 wants to merge 5 commits into
IMAP-Science-Operations-Center:devfrom
tech3371:release-lambda
Open

Release lambda handler logics#1383
tech3371 wants to merge 5 commits into
IMAP-Science-Operations-Center:devfrom
tech3371:release-lambda

Conversation

@tech3371
Copy link
Copy Markdown
Contributor

Change Summary

closes #1307

Overview

Release lambda handler logics. Shifted from using manifest files to only through release API/CLI. If manifest file is needed, we can add later but starting with simple approach first.

File changes

  • updated release API to only work through API key endpoint. We only want to make release through imap-data-access CLI which will validate if someone as write access through API key validation.
  • Added logics to release lambda handler

Testing

@tech3371 tech3371 requested a review from bryan-harter May 25, 2026 21:51
@tech3371 tech3371 self-assigned this May 25, 2026
@tech3371 tech3371 marked this pull request as draft May 26, 2026 17:37
@tech3371 tech3371 marked this pull request as ready for review May 27, 2026 02:05
@tech3371 tech3371 force-pushed the release-lambda branch 2 times, most recently from 250dade to 6b07853 Compare May 27, 2026 02:13
@tech3371 tech3371 requested review from lacoak21 and tmplummer May 27, 2026 02:16
@tech3371
Copy link
Copy Markdown
Contributor Author

I tested this in dev and website and it works.

Copy link
Copy Markdown
Contributor

@tmplummer tmplummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the infrastructure changes. Mostly dug into the release_api.py module.

Comment thread sds_data_manager/lambda_code/SDSCode/api_lambdas/release_api.py
Comment thread sds_data_manager/lambda_code/SDSCode/api_lambdas/release_api.py Outdated
Comment thread sds_data_manager/lambda_code/SDSCode/api_lambdas/release_api.py Outdated
Comment thread sds_data_manager/lambda_code/SDSCode/api_lambdas/release_api.py Outdated
Comment thread sds_data_manager/lambda_code/SDSCode/api_lambdas/release_api.py Outdated
Comment thread sds_data_manager/lambda_code/SDSCode/api_lambdas/release_api.py Outdated
Comment thread sds_data_manager/lambda_code/SDSCode/api_lambdas/release_api.py Outdated
Comment thread sds_data_manager/lambda_code/SDSCode/api_lambdas/release_api.py Outdated
Comment thread sds_data_manager/lambda_code/SDSCode/api_lambdas/release_api.py Outdated
Comment thread sds_data_manager/lambda_code/SDSCode/api_lambdas/release_api.py
}


def query_latest_science_files(
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmplummer I did a quick hack to get repoint query to work. Now it works. This function logic will change drastic once we implement release version. I think it will be simplified a lot. Right now, our different version for different products and level is making this logic long. But that will be simplified in the future.

Copy link
Copy Markdown
Contributor

@tmplummer tmplummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes. I did a quick review and didn't notice any other issues.

@tech3371
Copy link
Copy Markdown
Contributor Author

Thanks for making those changes. I did a quick review and didn't notice any other issues.

Thank you for those comments. Looks better and I like those simplification!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release API Lambda handler logics:

3 participants