Skip to content

Dependencies for lo/l1c/quickmap product#1325

Open
vineetbansal wants to merge 3 commits into
IMAP-Science-Operations-Center:devfrom
vineetbansal:vb/issue1324
Open

Dependencies for lo/l1c/quickmap product#1325
vineetbansal wants to merge 3 commits into
IMAP-Science-Operations-Center:devfrom
vineetbansal:vb/issue1324

Conversation

@vineetbansal
Copy link
Copy Markdown
Collaborator

Change Summary

closes #1324.

Overview

Added dependencies for lo/l1c/quickmap.

File changes

The bgrates product for lo/l1b is generated automatically by triggering the lo/l1b/goodtimes product, and the code wasn't hooked up to recognize the bgrates descriptor as valid, so I've removed those rows from the dependency config.

Testing

Copy link
Copy Markdown
Contributor

@tmplummer tmplummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we work on the batch starter/dependency manager refactoring, we need to keep the new dependency config files up to date with any changes here. Can you please add changes to this file as well? https://github.com/IMAP-Science-Operations-Center/sds-data-manager/blob/dev/sds_data_manager/lambda_code/SDSCode/pipeline_lambdas/dependency_refactoring/dependencies/imap_lo_dependencies.yaml

Comment on lines -843 to -845
lo, l1b, histrates, lo, l1b, bgrates, HARD, DOWNSTREAM
leapseconds, spice, historical, lo, l1b, bgrates, HARD_NO_TRIGGER, DOWNSTREAM
spacecraft_clock, spice, historical, lo, l1b, bgrates, HARD_NO_TRIGGER, DOWNSTREAM
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the L1B bgrates product going away?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're generated, but as a by-product of the goodtimes product, and not as a product that the dependency graph would recognize. These jobs would have raised a Unexpected descriptor warning and generated nothing, as per https://github.com/IMAP-Science-Operations-Center/imap_processing/blob/c88479f488ae0e0593023a877649ee1c2429ef07/imap_processing/lo/l1b/lo_l1b.py#L226

@tmplummer tmplummer added this to IMAP May 12, 2026
@vineetbansal vineetbansal marked this pull request as ready for review May 12, 2026 17:27
@vineetbansal
Copy link
Copy Markdown
Collaborator Author

@tmplummer - I'm a bit confused - there's no mention of either goodtimes or bgrates in https://github.com/IMAP-Science-Operations-Center/sds-data-manager/blob/dev/sds_data_manager/lambda_code/SDSCode/pipeline_lambdas/dependency_refactoring/dependencies/imap_lo_dependencies.yaml, but they're in the corresponding .csv:

lo, l1b, histrates, lo, l1b, goodtimes, HARD, DOWNSTREAM
leapseconds, spice, historical, lo, l1b, goodtimes, HARD_NO_TRIGGER, DOWNSTREAM
spacecraft_clock, spice, historical, lo, l1b, goodtimes, HARD_NO_TRIGGER, DOWNSTREAM

lo, l1b, histrates, lo, l1b, bgrates, HARD, DOWNSTREAM
leapseconds, spice, historical, lo, l1b, bgrates, HARD_NO_TRIGGER, DOWNSTREAM
spacecraft_clock, spice, historical, lo, l1b, bgrates, HARD_NO_TRIGGER, DOWNSTREAM

Are the yamls handcrafted by instrument teams and not auto-generated from the csv? Either is fine for my purpose of course and I can add what I want either way - just making sure.

@tmplummer
Copy link
Copy Markdown
Contributor

Are the yamls handcrafted by instrument teams and not auto-generated from the csv? Either is fine for my purpose of course and I can add what I want either way - just making sure.

No, they were generated by Tenzin. They are not being used yet, but will be once the refactor work is finished. It sounds like Lo yaml is just out of sync with the csv. If you can bring the things relevant to this PR up to date in the YAML and create an issue for any other discrepancies you identified, that would be most helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Add dependencies for IMAP-Lo quickmap

2 participants