Dependencies for lo/l1c/quickmap product#1325
Conversation
tmplummer
left a comment
There was a problem hiding this comment.
As we work on the batch starter/dependency manager refactoring, we need to keep the new dependency config files up to date with any changes here. Can you please add changes to this file as well? https://github.com/IMAP-Science-Operations-Center/sds-data-manager/blob/dev/sds_data_manager/lambda_code/SDSCode/pipeline_lambdas/dependency_refactoring/dependencies/imap_lo_dependencies.yaml
| lo, l1b, histrates, lo, l1b, bgrates, HARD, DOWNSTREAM | ||
| leapseconds, spice, historical, lo, l1b, bgrates, HARD_NO_TRIGGER, DOWNSTREAM | ||
| spacecraft_clock, spice, historical, lo, l1b, bgrates, HARD_NO_TRIGGER, DOWNSTREAM |
There was a problem hiding this comment.
Is the L1B bgrates product going away?
There was a problem hiding this comment.
They're generated, but as a by-product of the goodtimes product, and not as a product that the dependency graph would recognize. These jobs would have raised a Unexpected descriptor warning and generated nothing, as per https://github.com/IMAP-Science-Operations-Center/imap_processing/blob/c88479f488ae0e0593023a877649ee1c2429ef07/imap_processing/lo/l1b/lo_l1b.py#L226
|
@tmplummer - I'm a bit confused - there's no mention of either Are the yamls handcrafted by instrument teams and not auto-generated from the csv? Either is fine for my purpose of course and I can add what I want either way - just making sure. |
No, they were generated by Tenzin. They are not being used yet, but will be once the refactor work is finished. It sounds like Lo yaml is just out of sync with the csv. If you can bring the things relevant to this PR up to date in the YAML and create an issue for any other discrepancies you identified, that would be most helpful. |
Change Summary
closes #1324.
Overview
Added dependencies for lo/l1c/quickmap.
File changes
The
bgratesproduct forlo/l1bis generated automatically by triggering thelo/l1b/goodtimesproduct, and the code wasn't hooked up to recognize thebgratesdescriptor as valid, so I've removed those rows from the dependency config.Testing