Skip to content

Optimize: support pyswarm 1.0 return format#1717

Merged
Doresic merged 2 commits into
developfrom
fix-pyswarm-1-return
May 27, 2026
Merged

Optimize: support pyswarm 1.0 return format#1717
Doresic merged 2 commits into
developfrom
fix-pyswarm-1-return

Conversation

@Doresic
Copy link
Copy Markdown
Contributor

@Doresic Doresic commented May 27, 2026

pyswarm 1.0 changed pso to return an object with x and fun instead of the old (xopt, fopt) tuple.

This keeps support for both formats, so older pyswarm versions still work while CI can also use the new release.
I considered changing requirements to pyswarm >= 1.0.0, but it seems there is no more installation wheel for intel macs there anymore, so instead I decided to suggest keeping support for all versions.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 27, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.26%. Comparing base (e528598) to head (f1a1c4c).

Files with missing lines Patch % Lines
pypesto/optimize/optimizer.py 75.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1717      +/-   ##
===========================================
+ Coverage    78.93%   84.26%   +5.33%     
===========================================
  Files          164      164              
  Lines        14642    14645       +3     
===========================================
+ Hits         11557    12341     +784     
+ Misses        3085     2304     -781     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Doresic Doresic added this pull request to the merge queue May 27, 2026
Merged via the queue into develop with commit 541d5d7 May 27, 2026
18 checks passed
@Doresic Doresic deleted the fix-pyswarm-1-return branch May 28, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants