Skip to content

Failing Tests Track #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
PaulJonasJost wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Failing Tests Track #1665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c57be4
temporarily deactive to track changes
PaulJonasJost Dec 18, 2025
c9d29c7
Merge branch 'develop' into track_retests
PaulJonasJost Mar 5, 2026
09e42e5
Merge branch 'develop' into track_retests
PaulJonasJost Mar 24, 2026
f7bf93e
Julia test potential fix
PaulJonasJost Mar 24, 2026
797891e
Merge branch 'develop' into track_retests
PaulJonasJost Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/example/conversion_reaction/PEtabJl_module.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ petabModel = PEtabModel(pathYaml, verbose=true)
# A full list of options for PEtabODEProblem can be found at https://sebapersson.github.io/PEtab.jl/stable/API_choosen/
petabProblem = PEtabODEProblem(
petabModel,
ode_solver=ODESolver(Rodas5P(), abstol=1e-08, reltol=1e-08, maxiters=Int64(1e4)),
odesolver=ODESolver(Rodas5P(), abstol=1e-08, reltol=1e-08, maxiters=Int64(1e4)),
gradient_method=:ForwardDiff,
hessian_method=:ForwardDiff,
sparse_jacobian=nothing,
Expand Down
2 changes: 0 additions & 2 deletions test/base/test_roadrunner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ def test_petab_case(case, model_type, version):
def _execute_case_rr(case, model_type, version):
"""Run a single PEtab test suite case"""
case = petabtests.test_id_str(case)
if case == "0018" and model_type == "sbml" and version == "v1.0.0":
pytest.skip("https://github.com/ICB-DCM/pyPESTO/issues/1597")
logger.info(f"Case {case}")

# case folder
Expand Down
4 changes: 0 additions & 4 deletions test/petab/test_petabSimulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@
)
def test_petab_case(case, model_type, version):
"""Wrapper for _execute_case for handling test outcomes"""
# FIXME https://github.com/ICB-DCM/pyPESTO/issues/1583
if model_type == "sbml" and version == "v1.0.0" and case == "0020":
pytest.xfail(reason="https://github.com/ICB-DCM/pyPESTO/issues/1583")

try:
_execute_case(case, model_type, version)
except Exception as e:
Expand Down
Loading