Harden filesystem-server networking and path handling - #14
Merged
Conversation
- Make the HTTP bind address configurable, default to loopback, and require a bearer token before listening on non-loopback addresses - Tighten path validation for directory creation and add regression tests - Refresh qr_code_server Python dependencies - Ignore the local todo/ working directory Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Jonathan Springer <jps@s390x.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--bind, defaulting to loopback, and require--auth-token(orFILESYSTEM_SERVER_AUTH_TOKEN) before listening on non-loopback addresses; requests are then checked for a bearer tokentodo/working directoryTest plan
cargo fmt,cargo clippy --all-targets,cargo test— 87 lib + 9 integration tests pass (16 new)uv lock --checkanduv run pytest— 97 tests pass