Feature/dockerize#12
Open
Ke-vin-S wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR dockerizes the application by introducing container configuration for both the frontend and backend, while also integrating related services.
- Added a Dockerfile for the Angular frontend.
- Introduced a docker-compose.yaml to orchestrate backend, frontend, PostgreSQL, Adminer, IPFS, Kafka, and Zookeeper.
- Updated the backend configuration to use dj-database-url for database connectivity.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/Dockerfile | Added a Dockerfile to containerize the Angular app. |
| docker-compose.yaml | Introduced service orchestration for all components. |
| blocktrack_backend/requirements.txt | Added dj-database-url as a new dependency. |
| blocktrack_backend/blocktrack_backend/settings.py | Updated database configuration using dj-database-url. |
| blocktrack_backend/Dockerfile | Added a Dockerfile to containerize the Django backend. |
| .env.example | Provided example environment variable settings. |
|
|
||
| # 🧿 IPFS node | ||
| ipfs: | ||
| image: ipfs/go-ipfs:latest |
There was a problem hiding this comment.
[nitpick] Consider pinning a specific version for the ipfs/go-ipfs image rather than using ':latest' to improve reproducibility and stability.
Suggested change
| image: ipfs/go-ipfs:latest | |
| image: ipfs/go-ipfs:v0.18.1 |
| - kafka_zookeeper | ||
|
|
||
| kafka_zookeeper: | ||
| image: bitnami/zookeeper:latest |
There was a problem hiding this comment.
[nitpick] It is advisable to specify a fixed version for bitnami/zookeeper instead of using ':latest' to avoid unexpected changes from future updates.
Suggested change
| image: bitnami/zookeeper:latest | |
| image: bitnami/zookeeper:3.8.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.