4.X: US State with Subsections - MD, KY, RI, IN - #109
Open
yuzawa-san wants to merge 17 commits into
Open
Conversation
…subsection-headers
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i came up with this independently to #104 which does not have support for the subsection headers per the spec (at least how i understand it). i came up with this before the spec was finalized but it appears to us the semantics i expected, specifically around the encoding of subsections. i had previously conveyed my concern around how it was not possible to encode the core section with subsection id 0 in the fibonacci string since they do not support encoding 0. given that the spec addresses that:
this introduces a new section subclass which automates this type of state schema
there is no longer need to unencodable booleans since the presence was in the header.