ci: migrate npm release to OIDC trusted publishing#68
Merged
Conversation
Replace the long-lived NPM_TOKEN secret with npm's OIDC trusted publishing: - Add id-token: write permission required for OIDC token exchange - Upgrade npm to latest to ensure trusted publishing support (requires npm >= 11.5.1) - Drop the _authToken config and NPM_TOKEN env; npm publish now authenticates to the registry via OIDC Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019zx7bvzz1yUn36wLtyynxM
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f8d468718
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
npm trusted publishing requires the package's repository.url to match the GitHub repository, otherwise the OIDC publish handshake fails. package.json had no repository field, so add repository, bugs, and homepage pointing at Hyphen/browser-sdk. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019zx7bvzz1yUn36wLtyynxM
jaredwray
commented
Jun 21, 2026
Address review feedback to standardize on pnpm: - Publish with pnpm publish (OIDC trusted publishing) instead of npm - Drop the npm upgrade step; pnpm is provided by pnpm/action-setup - Remove the redundant corepack enable step now that pnpm/action-setup installs pnpm Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019zx7bvzz1yUn36wLtyynxM
jaredwray
commented
Jun 21, 2026
Per review feedback, drop the cache: 'pnpm' option from the Node.js setup step in the release workflow. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019zx7bvzz1yUn36wLtyynxM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the npm release workflow from a long-lived
NPM_TOKENsecret to npm's OIDC trusted publishing. This removes the need to store and rotate a publish token in repository secrets — GitHub Actions exchanges a short-lived OIDC token with the npm registry at publish time.Changes
id-token: writepermission — required so the workflow can request the OIDC token used for the registry handshake.npm install -g npm@latest) — trusted publishing requires npm ≥ 11.5.1.npm config set //registry.npmjs.org/:_authTokenline and theNPM_TOKENenv.npm publishnow authenticates via OIDC.Follow-up (one-time, in npm settings)
For this to work end-to-end, the package's Trusted Publisher must be configured on npmjs.com for
@hyphen/browser-sdk, pointing at this repo and therelease.yamlworkflow. Once verified, theNPM_TOKENsecret can be deleted from the repository settings.🤖 Generated with Claude Code
https://claude.ai/code/session_019zx7bvzz1yUn36wLtyynxM
Generated by Claude Code