root - chore: upgrade hookified (breaking)#66
Merged
Conversation
- hookified 2.1.1 → 3.0.0 (major)
Runtime dependency; `Toggle extends Hookified`. The APIs the SDK
relies on are unchanged in v3: the Hookified constructor still
accepts `{ throwOnEmptyListeners: false }` (preserving the
error-swallowing behavior in src/index.ts) and `emit()` is
unchanged. v3 only adds APIs (ParallelHook). No source changes
required; `pnpm build` and the error-path test both pass.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UXjL3LurbiGcLiiep7Fnvr
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
hookifiedto v3 — runtime phase, PR 2 of 2 (final dependency-management item).Versions
hookified2.1.1→3.0.0(major)Impact
hookifiedis the SDK's one runtimedependency;Toggle extends Hookified. The APIs the SDK uses are unchanged in v3:Hookifiedconstructor still accepts{ throwOnEmptyListeners: false }— this is what keepsemit(ToggleEvents.Error, …)from re-throwing when no listener is attached, so the SDK can swallow eval errors and return the caller's default (src/index.ts:55).emit()is unchanged; v3 only adds APIs (ParallelHook).No source changes required.
Tests
pnpm buildpasses (hookified is bundled into the browser build)pnpm test— 151/156 pass; no new failuresindex.test.ts"should return defaultValue when error occurs") passes →throwOnEmptyListeners: falsebehavior preservedThe only failures are the 5 live-platform
test/index-evals.test.tstests (needHYPHEN_PUBLIC_API_KEY/HYPHEN_APPLICATION_ID, absent in the local sandbox) — identical tomain, unrelated to this change. CI has those secrets.Breaking notes
Labeled
(breaking)because the dependency crossed a major version. For this repo there's no breaking impact — the constructor option andemit()behavior the SDK depends on are unchanged and verified.🤖 Generated with Claude Code
Generated by Claude Code