root - chore: upgrade @hyphen/sdk (breaking)#65
Merged
Conversation
- @hyphen/sdk 3.0.1 → 4.0.0 (major) Dev/test-only dependency; used solely for env() in test/index-evals.test.ts. The env() export and signature are unchanged in v4, so no code changes are required and there is no impact on the published package or its consumers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UXjL3LurbiGcLiiep7Fnvr
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the @hyphen/sdk dependency from version 3.0.1 to 4.0.0 in package.json and updates the corresponding lockfile pnpm-lock.yaml along with its transitive dependencies. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
@hyphen/sdkto v4 — runtime phase, PR 1 of 2.Versions
@hyphen/sdk3.0.1→4.0.0(major)Impact
@hyphen/sdkis a dev/test-only dependency, used in exactly one place —env()intest/index-evals.test.ts. In v4 theenvexport and its signature (env(options?: EnvOptions): void) are unchanged, so no code changes are required. No effect on the published package or its consumers. (Other v4 API changes — e.g.ToggleEventsbecoming a type-only export, dual ESM/CJS type files — aren't used here.)Tests
pnpm buildpassespnpm test— 151/156 pass; no new failuresThe only failures are the 5 live-platform
test/index-evals.test.tstests (needHYPHEN_PUBLIC_API_KEY/HYPHEN_APPLICATION_ID, absent in the local sandbox) — identical tomain, unrelated to this change. CI has those secrets.Breaking notes
Labeled
(breaking)only because the dependency crossed a major version; for this repo there is no breaking impact (dev-only usage,env()unchanged).🤖 Generated with Claude Code
Generated by Claude Code