Update 1.0.0 (massive rewrite update)

[HyperCodec]

No description provided.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 17 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

src/activation.rs:88

• ActivationRegistry::activations_in_scope uses a.scope.contains(scope) without handling scope == NeuronScope::NONE. Because every bitflags value contains NONE (0 bits), calling activations_in_scope(NeuronScope::NONE) will currently return all activations, contradicting the documented meaning of NONE (“will not be randomly placed anywhere”).

Fix: explicitly return an empty vec for scope == NeuronScope::NONE, or add a guard in the filter (e.g., scope != NONE && a.scope != NONE && a.scope.contains(scope)).
src/activation.rs:206

• ActivationFn deserialization panics when an activation name is missing (panic!("Activation function {name} not found")). Panicking inside Deserialize makes malformed/untrusted input able to crash consumers; serde expects this to return a D::Error instead.

Fix: replace the panic with Err(serde::de::Error::custom(...)) (and avoid unwrap() by using ok_or_else).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[HyperCodec]

@copilot open a new pull request to apply changes based on the comments in this thread

[Copilot]

@HyperCodec I've opened a new pull request, #110, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 17 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/activation.rs:29

• activation_fn! passes stringify!($F).into() as the activation name, but ActivationFn::new takes name: &'static str. This will not compile (it produces a String). Use stringify!($F) directly (and similarly for the scoped macro arm).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[HyperCodec]

ok my codespace randomly deleted itself for no reason.

[HyperCodec]

@copilot the crossover test seems to always fail due to cyclic linkages. this may be related to the recent changes to the is_connection_safe method in this PR. find the issue and make your own PR to fix it.

[Copilot]

@HyperCodec I've opened a new pull request, #111, to work on those changes. Once the pull request is ready, I'll request review from you.