Issue 107 remove vt tables#144
Open
perrymanmd wants to merge 3 commits into
Open
Conversation
Contributor
|
Okay, so this is entirely my fault... we can't remove these yet. OpenDCS still depends on the CWMS VT package for the screening algorithm. More motivation to move those to OpenDCS... now to find the time. |
MikeNeilson
requested changes
May 1, 2026
Contributor
MikeNeilson
left a comment
MikeNeilson
left a comment
There was a problem hiding this comment.
No changes required... but we have to wait on this one.
Contributor
|
It exists, opendcs/opendcs#355. To be blunt, I don't want to bring these tables into OpenDCS. The design is... not flexible, to say the least. Needs some consideration. There's also a partial implementation given the ALARM_ tables, it has some of the same considerations. Bascially, the OpenDCS ALARM and Screening Code need to be unified. So I think we're better off waiting on this one. OR deleting everything except the screening elements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107
Parent issue is #106
The
schema/src/updateScripts/update_issue_107-remove_vt_tables.sqlupdate script does not test or update the schema version like a release version update does.