DEV: pin github actions to hashes - #69
Merged
Merged
Conversation
Reviewer's GuidePins all GitHub Actions used in testing and release workflows to specific commit hashes, updates some action versions, and adjusts Coveralls usage and macOS tap trust handling. Flow diagram for updated testing_develop GitHub Actions workflowflowchart TD
A[testing_develop job start] --> B["actions_checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0"]
B --> C["astral_sh_setup_uv@11f9893b081a58869d3b5fccaea48c9e9e46f990"]
C --> D["actions_setup_python@ece7cb06caefa5fff74198d8649806c4678c61a1"]
D --> E[nox test matrix]
E --> F{runner.os == macOS?}
F -->|yes| G["brew trust coverallsapp/coveralls"]
F -->|no| H[skip tap trust]
G --> I["coverallsapp_github_action@5cbfd81b66ca5d10c19b062c04de0199c215fb6e"]
H --> I
I --> J["Coveralls Finished job using coverallsapp_github_action@5cbfd81b66ca5d10c19b062c04de0199c215fb6e"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
actions/setup-pythonpin updates from v6.2.0 to a digest commented as v6.3.0; if the intention was only to pin, consider either keeping the original version or explicitly calling out the upgrade in the PR title/description. - The new
brew trust coverallsapp/coverallsstep introduces a dependency on Homebrew’s tap trust semantics; it may be worth adding a brief inline comment explaining why this is needed to avoid confusion for future maintainers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `actions/setup-python` pin updates from v6.2.0 to a digest commented as v6.3.0; if the intention was only to pin, consider either keeping the original version or explicitly calling out the upgrade in the PR title/description.
- The new `brew trust coverallsapp/coveralls` step introduces a dependency on Homebrew’s tap trust semantics; it may be worth adding a brief inline comment explaining why this is needed to avoid confusion for future maintainers.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Pin GitHub Actions used in CI and release workflows to specific commit SHAs for improved reproducibility and security.
Build:
CI: