Fixed mouse movement lag - #138
Open
morie197 wants to merge 2 commits into
Open
Conversation
It doesn't lag anymore, I haven't a clue what is causing the lag but for now it does not lag :)
I guess cinemachine was causing the lag when moving the mouse? I switched to manually setting the input axis in code instead of using a CinemachineInputProvider and the lag seemed to go away :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it appears that the Cinemachine CinemachineInputProvider component, when passing the action from the map in, wasn't unsubscribing, causing massive lag after enough restarts when moving the mouse. Setting the input axis via code appears to remove any lag.