Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Comment thread
matt-bernstein marked this conversation as resolved.
Resolved
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
run: poetry install

- name: Run black
run: poetry run pytest --black .
run: poetry run black --check .

run_pytest:
name: "pytest ${{ matrix.os }} | ${{ matrix.python-version }}"
Expand Down
28 changes: 25 additions & 3 deletions adala/memories/vectordb.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,29 @@
from .base import Memory
from uuid import uuid4
from pydantic import BaseModel, Field, model_validator
from chromadb.utils import embedding_functions
from typing import Any, List, Dict
from typing import Any, List, Dict, Optional

from openai import OpenAI


class OpenAIEmbeddingFunction:
"""
ChromaDB embedding function using the OpenAI Python SDK (v1+).

ChromaDB's built-in `embedding_functions.OpenAIEmbeddingFunction` relies on the
legacy `openai.Embedding` API which was removed in openai>=1.0.
"""

def __init__(
self, *, model_name: str, api_key: str, base_url: Optional[str] = None
):
self._model_name = model_name
self._client = OpenAI(api_key=api_key, base_url=base_url)

def __call__(self, input: List[str]) -> List[List[float]]:
resp = self._client.embeddings.create(model=self._model_name, input=input)
# Keep ordering stable
return [item.embedding for item in resp.data]


class VectorDBMemory(Memory):
Expand All @@ -22,12 +43,13 @@ class VectorDBMemory(Memory):
@model_validator(mode="after")
def init_database(self):
self._client = chromadb.Client()
self._embedding_function = embedding_functions.OpenAIEmbeddingFunction(
self._embedding_function = OpenAIEmbeddingFunction(
model_name=self.openai_embedding_model, api_key=self.openai_api_key
)
self._collection = self._client.get_or_create_collection(
name=self.db_name, embedding_function=self._embedding_function
)
return self

def create_unique_id(self, string):
return hashlib.md5(string.encode()).hexdigest()
Expand Down
4 changes: 2 additions & 2 deletions adala/skills/collection/prompt_improvement.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
AfterValidator,
)
from adala.skills import Skill
from typing import Any, Dict, List, Optional, Union
from typing import Any, Dict, List, Optional, Union, Type
from typing_extensions import Annotated
from adala.skills import AnalysisSkill
from adala.utils.parse import parse_template
Expand Down Expand Up @@ -67,7 +67,7 @@ class PromptImprovementSkill(AnalysisSkill):
input_prefix: str = "" # Used to provide additional context for the input
input_separator: str = "\n"

response_model = PromptImprovementSkillResponseModel
response_model: Type[BaseModel] = PromptImprovementSkillResponseModel

@model_validator(mode="after")
def validate_prompts(self):
Expand Down
9,024 changes: 5,044 additions & 3,980 deletions poetry.lock

Large diffs are not rendered by default.

6 changes: 2 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ classifiers = [
requires-python = ">=3.10,<4"
dependencies = [
"pandas (==2.2.3)",
"openai (>=1.60.2,<2.0.0)",
"openai (>=2.0.0,<3.0.0)",
"guidance (==0.0.64)",
"pydantic (>=2,<3)",
"rich (>=13,<14)",
Expand Down Expand Up @@ -44,7 +44,7 @@ dependencies = [
"litellm (>=1.76.1,<2.0.0)",
#"litellm @ https://github.com/HumanSignal/litellm/archive/9deadf35b9b2ff351388abc3a2ea144ed93ca013.zip",
"pandarallel (>=1.6.5,<2.0.0)",
"instructor (==1.4.3)",
"instructor (>=1.14.5, <2.0.0)",
"async-lru (>=2.0.5,<3.0.0)",
"jinja2 (>=3.1.6,<4.0)"
]
Expand All @@ -63,7 +63,6 @@ python = ">=3.10,<4"
pytest = "^8.3.5"
pytest-cov = "^4.1.0"
black = "^24.8.0"
pytest-black = "^0.3.12"
mkdocs = "^1.5.3"
mkdocs-jupyter = "^0.24.3"
mkdocs-material = "^9.4.7"
Expand All @@ -81,7 +80,6 @@ pytest-recording = "0.13.2"
mypy = "^1.15.0"
pytest-benchmark = "^5.1.0"
pytest-profiling = "^1.8.1"
openai-responses = "^0.12.0"

[build-system]
requires = ["poetry-core>=1.0.0"]
Expand Down
225 changes: 0 additions & 225 deletions tests/cassettes/test_custom_endpoints/test_custom_endpoint_simple.yaml

This file was deleted.

14 changes: 12 additions & 2 deletions tests/conftest.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import pytest
import httpx
from unittest import mock
import os

# from contextlib import asynccontextmanager
import pytest_asyncio
Expand All @@ -13,12 +14,21 @@
def vcr_config():
return {
"filter_headers": ["authorization", "api-key", "x-api-key"],
"filter_query_parameters": ["api_key", "key"],
"match_on": ("method", "scheme", "host", "port", "path", "query", "body"),
"filter_query_parameters": ["api_key", "key", "api-version"],
# Dependency upgrades (e.g. OpenAI/LiteLLM/Instructor) frequently change request
# bodies in non-semantic ways; matching on body makes existing cassettes brittle.
"match_on": ("method", "scheme", "host", "port", "path", "query"),
}


def pytest_configure(config):
# Newer OpenAI / LiteLLM versions error early if no API key is present,
# even when requests are replayed from VCR cassettes. Provide harmless defaults.
os.environ.setdefault("OPENAI_API_KEY", "test")
os.environ.setdefault("AZURE_OPENAI_API_KEY", "test")
os.environ.setdefault("GOOGLE_API_KEY", "test")
os.environ.setdefault("GEMINI_API_KEY", "test")

config.addinivalue_line("markers", "use_openai: mark test as requiring OpenAI key")
config.addinivalue_line(
"markers", "use_azure: mark test as requiring Azure OpenAI key"
Expand Down
Loading
Loading