Add Dropwizard 1.0.0 Support

[heldeen]

This adds support for dropwizard 1.0. I didn't see a contributions type doc so let me know if there is one and/or there need to be any changes for this to be merged.

I'm not completely happy with the baseInjector concept I introduced in GuiceBundle but I wanted to get some feedback before I over engineered it. Everything else seems straight forward to me.

[heldeen]

Oh, also let me know how you'd like me to handle the aopalliance classpath dups that show up. Adding an exclusion to either guice or hk2-api results in an error like:

[WARNING] Exclusions must be removed for managed dependency org.glassfish.hk2:hk2-api:jar

[jhaber]

Thanks so much! I'll try to get this reviewed and merged this week

[mtraynham]

@heldeen, thanks for this! I tried out your branch and it works great! I excluded aopalliance-repackaged on the hk2-api as you've described above and didn't encounter any issue. Just one thing I noticed when building is that metrics-core needed to be added as a dependency.

diff --git a/pom.xml b/pom.xml
index 63f775e..311e353 100755
--- a/pom.xml
+++ b/pom.xml
@@ -66,6 +66,12 @@
                 <groupId>org.glassfish.hk2</groupId>
                 <artifactId>hk2-api</artifactId>
                 <version>2.4.0-b34</version>
+                <exclusions>
+                    <exclusion>
+                        <groupId>org.glassfish.hk2.external</groupId>
+                        <artifactId>aopalliance-repackaged</artifactId>
+                    </exclusion>
+                </exclusions>
             </dependency>
             <dependency>
                 <groupId>javax.ws.rs</groupId>
@@ -144,6 +150,10 @@
         </dependency>
         <dependency>
             <groupId>io.dropwizard.metrics</groupId>
+            <artifactId>metrics-core</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>io.dropwizard.metrics</groupId>
             <artifactId>metrics-healthchecks</artifactId>
         </dependency>
         <dependency>

[heldeen]

I'm a little weary of excluding aopalliance-repackaged on the hk2-api since that jar contains more classes than the aopalliance jar it's conflicting with. Do you have any knowledge around if or how those extra classes are used?

My bad on the metrics-core dep. I've got it locally but missed it in the commit because I was mucking w/ the dup classes problem.

[mtraynham]

I think your guess is as good as mine. I tried the exclusion on both. Both passed the tests of this library and both worked with my own webapp. I don't really use Glassfish projects or h2k, so I can't comment on the usage of it. Maven Central does show the package age for each, the Glassfish version is much newer (2016) compared to Guice's dependency (2007).

[heldeen]

Those are my findings as well @mtraynham. We'll go w/ it until it is a problem. 😄

[mtraynham]

Sounds good to me! Thanks again 🍻

[jhaber]

We've had 2.4.0-b34 with this exclusion in our basepom for a while without issue so I think it should be fine

[jhaber]

I just pushed cb924b0 with some POM cleanup and cut a release for version 1.0.0, thanks for the PR!

[vvondra]

I'm having trouble injecting Provider<SecurityContext> in my services, I think it's because the install call here is after the initInjector call.

@jhaber @heldeen is there any way you see to make the Jersey services like SecurityContext available?

[heldeen]

@vvondra, I am able to inject Provider<SecurityContext> in my quick tests. Would you want to create an issue w/ a simple example project that can duplicate the issue you are seeing?

[vvondra]

I tried to sum up an example in #87

https://github.com/HubSpot/dropwizard-guice/pull/87/files#r75596536

Maybe it's because I'm not injecting the Provider to a resource, but to a service that is a dependecy of the resource?