Replace panic-based validation with typed errors across all modules

dongle-smartcontract/src/errors.rs

@@ -41,8 +41,12 @@ pub enum ContractError {
     CannotRemoveLastAdmin = 17,
     /// Admin not found
     AdminNotFound = 18,
-    /// Contract already initialized
-    AlreadyInitialized = 19,
+    /// Invalid project name - empty or whitespace only
+    InvalidProjectName = 19,
+    /// Invalid project description - empty or whitespace only
+    InvalidProjectDescription = 20,
+    /// Invalid project category - empty or whitespace only
+    InvalidProjectCategory = 21,
 }
 
 // Legacy alias to avoid breaking any code that uses `Error` directly

dongle-smartcontract/src/lib.rs

@@ -72,7 +72,10 @@ impl DongleContract {
         ProjectRegistry::register_project(&env, params)
     }
 
-    pub fn update_project(env: Env, params: ProjectUpdateParams) -> Result<Project, ContractError> {
+    pub fn update_project(
+        env: Env,
+        params: ProjectUpdateParams,
+    ) -> Result<Project, ContractError> {
         ProjectRegistry::update_project(&env, params)
     }
 

dongle-smartcontract/src/project_registry.rs

@@ -18,14 +18,15 @@ impl ProjectRegistry {
     ) -> Result<u64, ContractError> {
         require_self_auth(&params.owner);
 
+        // Validate inputs - return typed errors instead of panicking
         if params.name.is_empty() {
-            panic!("InvalidProjectName");
+            return Err(ContractError::InvalidProjectName);
         }
         if params.description.is_empty() {
-            panic!("InvalidProjectDescription");
+            return Err(ContractError::InvalidProjectDescription);
         }
         if params.category.is_empty() {
-            panic!("InvalidProjectCategory");
+            return Err(ContractError::InvalidProjectCategory);
         }
 
         // Check if project name already exists
@@ -95,18 +96,31 @@ impl ProjectRegistry {
         env: &Env,
         params: ProjectUpdateParams,
     ) -> Result<Project, ContractError> {
-        let mut project =
-            Self::get_project(env, params.project_id).ok_or(ContractError::ProjectNotFound)?;
+        let mut project = Self::get_project(env, params.project_id)
+            .ok_or(ContractError::ProjectNotFound)?;
 
-        require_owner_auth(&params.caller, &project.owner)?;
+        params.caller.require_auth();
+        if project.owner != params.caller {
+            return Err(ContractError::Unauthorized);
+        }
 
+        // Validate and update fields
         if let Some(value) = params.name {
+            if value.is_empty() {
+                return Err(ContractError::InvalidProjectName);
+            }
             project.name = value;
         }
         if let Some(value) = params.description {
+            if value.is_empty() {
+                return Err(ContractError::InvalidProjectDescription);
+            }
             project.description = value;
         }
         if let Some(value) = params.category {
+            if value.is_empty() {
+                return Err(ContractError::InvalidProjectCategory);
+            }
             project.category = value;
         }
         if let Some(value) = params.website {
@@ -124,8 +138,6 @@ impl ProjectRegistry {
             .persistent()
             .set(&StorageKey::Project(params.project_id), &project);
 
-        publish_project_updated_event(env, params.project_id, project.owner.clone());
-
         Ok(project)
     }