docs: HPC OS compatibility audit for chemsmart agent pipeline#65
docs: HPC OS compatibility audit for chemsmart agent pipeline#65Hongjiseung-ROK wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a detailed HPC OS compatibility audit for the chemsmart agent, covering dependency layers, GLIBC compatibility, and login-node constraints across various Linux distributions. Feedback indicates that the binary compatibility section should include additional compiled dependencies like rdkit and pymatgen. Furthermore, a discrepancy was identified between the dependencies listed for the audited commit and those currently present in the repository.
| Packages that matter for binary compatibility: | ||
| - `pydantic-core` | ||
| - `numpy` | ||
| - `scipy` | ||
| - `PyYAML` | ||
| - `watchdog` | ||
| - possibly `jiter` pulled by current `openai` / `anthropic` |
There was a problem hiding this comment.
The binary compatibility analysis in Section 1.7 appears to omit several major compiled dependencies present in the project's pyproject.toml, such as rdkit, pymatgen, pandas, scikit-learn, pillow, and spyrmsd. Since these packages contain compiled extensions (C/C++/Rust), their ABI compatibility is critical for a comprehensive HPC OS audit. rdkit, in particular, is known for having complex dependency requirements that can be challenging in restricted HPC environments.
| Packages that matter for binary compatibility: | |
| - `pydantic-core` | |
| - `numpy` | |
| - `scipy` | |
| - `PyYAML` | |
| - `watchdog` | |
| - possibly `jiter` pulled by current `openai` / `anthropic` | |
| Packages that matter for binary compatibility: | |
| - `pydantic-core` | |
| - `numpy` | |
| - `scipy` | |
| - `rdkit` | |
| - `pymatgen` | |
| - `pandas` | |
| - `scikit-learn` | |
| - `PyYAML` | |
| - `watchdog` | |
| - `pillow` | |
| - `spyrmsd` | |
| - possibly `jiter` pulled by current `openai` / `anthropic` |
| - `pyproject.toml` at `20cbcdb9` declares: | ||
| - `requires-python = "~=3.10"` | ||
| - main deps include `anthropic`, `openai`, `python-dotenv`, `pydantic` | ||
| - TUI extra includes `textual`, `watchdog`, `pyperclip` | ||
| - `environment.yml` pins `python=3.10` and includes `anthropic`, `openai`, | ||
| `pydantic`, and `python-dotenv` in the conda dependency list. |
There was a problem hiding this comment.
There is a significant discrepancy between the dependencies described in this audit (for commit 20cbcdb9) and the current state of the repository (36f13c6e). Specifically, pydantic, openai, anthropic, python-dotenv, textual, watchdog, and pyperclip are missing from the pyproject.toml and environment.yml files provided in the current worktree. It would be helpful to clarify if these dependencies were removed or if they are expected to be added in a separate PR, as this may confuse users trying to deploy the current head based on this audit.
Summary
docs/research/hpc_os_compatibility.mdchemsmart agentpipeline at commit20cbcdb9against common HPC login-node OS familiesScope
20cbcdb9Notes
bin/plan.mdwas intentionally skipped per task instructions because it does not existValidation