Upgrading firmware with JFFS enabled is not possible

[zakk87]

ftup -a

WARNING: JFFS is enabled.
Make sure you have a backup of its content as
it is not guaranteed the content of JFFS
will be preserved after a firmware upgrade.
Auto unmount JFFS during upgrade is enabled.

JFFS will be stopped and unmounted

To cancel press CTRL+C

Stopping JFFS... Unable to unmount JFFS

ERROR: Upgrading firmware with JFFS enabled is not possible. Optionally you can enable 'Unmount JFFS during upgrade' in the webUI in 'Administration > Admin Access'

[HommeOursPorc]

Been a long time since I've worked with JFFS. I'll check this out, thanks for reporting.

At that moment, where you in the /jffs directory?

[zakk87]

Ouch, I think that after “Make sure you have a backup of its content […]” I used SCP to connect to my router and copied the content to my PC. After that, JFFS was unmounted and I couldn’t update anything. After disabling JFFS in Administration → JFFS, I was able to use FTP again.

[HommeOursPorc]

Yes, the script will terminate anything jffs related but as long as it is busy, jffs will be there. The second you exit or any app exit the jffs directory, it will be unmounted and the module is also removed if I remember correctly.

To restore jffs you'll need to do service jffs start

Again, if I remember correctly. It's been too long since I made this 🥴

[wellloaded]

On this topic, I would skip the JFFS countdown (and other countdowns) when -y is in use.

[HommeOursPorc]

I need to review this part of the code. I don't like what I did. It's on my to-do list 🙂

[HommeOursPorc]

Ouch, I think that after “Make sure you have a backup of its content […]” I used SCP to connect to my router and copied the content to my PC. After that, JFFS was unmounted and I couldn’t update anything. After disabling JFFS in Administration → JFFS, I was able to use FTP again.

The script unmount JFFS, stop the JFFS service and remove the JFFS kernel module. If anything is using JFFS, it will stay active until you change directory or until app using the directory end/stop.

To re-enabled JFFS you can do service jffs start from the shell.

I made some updates:
https://github.com/HommeOursPorc/ftup/releases/tag/ftup_v0.52-test-005

Check this is out and let me know if anything is wrong/doesn't work 🙂

[HommeOursPorc]

ftup -a

Oh, and -a is currently disabled because it is a "full auto upgrade" mode and it is not proven that the script can correctly identify every models yet.

But you can use ftup -g instead. This will fetch the latest firmware. This option doesn't check if an upgrade is needed like -a, -g will fetch the latest firmware no matter what. You can specify the version number and/or build, but this is optional.

Have fun 😊

[HommeOursPorc]

Doh! There's a bug in Test version 005, it ask to unmount JFFS even if it is already unmounted. Not a deal breaker, just annoying. Plus I want to change the behavior a little. I'm running out of time today. I'll try to fix it soon.

[HommeOursPorc]

On this topic, I would skip the JFFS countdown (and other countdowns) when -y is in use.

The idea of the countdowns was for the script, not the GUI. The goal was to give the users a chance to react if necessary without stopping the script and wait for user input. So it is a way to keep the script safe when using the script while keeping a "unattended" mode that can run without interruption. IMO it is the best of both world. A few more seconds to execute if unattended and still safe if used "in person".

I'm not sure how yet, but I suppose we don't need them for the GUI implementation.

[HommeOursPorc]

On this topic, I would skip the JFFS countdown (and other countdowns) when -y is in use.

I may have an idea. I didn't knew we have the option with our version of read ... IIRC last time I tried it didn't work? Something like this:

n=0 ; for i in $(seq 5 -1 1); do echo -ne "\r$i" ; read -t 1 -n 1 && { n=1 ; break ; } ; done ; [ $n -eq 0 ] && echo

For the shell --> a countdown but it can be skipped by pressing enter
For the GUI --> I'll add extra code to bypass any countdown or maybe, if it works, I will force them to a timeout of 0 second.

What do you think? Safety is kept but you can also speed things up, make sense?

[HommeOursPorc]

Off topic a little:

@wellloaded maybe we could add the "reserve colors" command to nvram_ops ? It reverse the font and background colors like this:

[HommeOursPorc]

Off topic a little:

@wellloaded maybe we could add the "reserve colors" command to nvram_ops ? It reverse the font and background colors like this:

Completely off topic, but look at this cool generator !!
https://ansi-generator.pages.dev/

[HommeOursPorc]

On this topic, I would skip the JFFS countdown (and other countdowns) when -y is in use.

I may have an idea. I didn't knew we have the option with our version of read ... IIRC last time I tried it didn't work? Something like this:

n=0 ; for i in $(seq 5 -1 1); do echo -ne "\r$i" ; read -t 1 -n 1 && { n=1 ; break ; } ; done ; [ $n -eq 0 ] && echo

For the shell --> a countdown but it can be skipped by pressing enter For the GUI --> I'll add extra code to bypass any countdown or maybe, if it works, I will force them to a timeout of 0 second.

What do you think? Safety is kept but you can also speed things up, make sense?

I added the possibility to skip countdowns by pressing enter. I will test this extensively when I get the time and then I'll post a new pre-release.

I still need to think about the special GUI option... I'll sleep on it 🙂

[HommeOursPorc]

Please tell me what you think and if there's still any problem with JFFS handling

https://github.com/HommeOursPorc/ftup/releases/tag/v0.52