fix: render public lobby and serve crawler metadata - #9
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
HomenShum
marked this pull request as ready for review
September 9, 2026 09:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search visitors previously received an empty root, and
/robots.txtand/sitemap.xmlreturned the same HTML shell. Prerender the existing lobby through Vite, share its provider composition with hydration, link styles directly, and serve real canonical metadata and crawler files. Keep room deep links and the comparison route on their existing client paths. Controls remain disabled until hydration; a no-script explanation, main landmark and explicit input labels support the initial page.Keep the demo's browser-only tracing scheduler outside the server entry. Importing it during rendering left a referenced MessagePort after a successful build; the new scenarios exercise actual child-process termination. CI now also checks Convex types and builds the public output.
Patch nine development lock records: eight coupled Vitest packages to 4.1.11 and baseline-browser-mapping to 2.11.0. Package.json, all 44 production lock records and 19 installed production packages are unchanged. The old runtime is preserved. Ordinary
npm ciand a fresh full audit pass with zero findings; built HTML/CSS/JS/crawler bytes are unchanged by the dependency patch.Validation:
The handoff documents source-bound verification and remaining limits. Local evidence is not canonical deployment verification, a complete accessibility/security certification, or a search-ranking claim. Full portfolio grades, selected-label truncation, detailed room/demo layouts, physical devices, microphone/audio, real providers and durable hosted restart remain open. Independent review was unavailable because of the account usage limit; author readback is not independent approval.
Exact-source CI: CI 34303567950 and conformance 34303568383 pass for
e09fa427ea72fd229304f8519643bbd920d743ef. The tested merge89919c2a1966389d406c6ec3eb6da06057cabf22has the candidate's exact tree. Linux CI passes all three typechecks, build, 56 citations and 60 tests in 10 files, with no skipped workflow steps. The browser matrix above is local evidence. Conformance's separate NodeKit-main installation still reports five advisories (three moderate/two high); the reviewed NodeKit patch is not yet adopted. Provider previews report success, but anonymous canonical-domain verification still returns the original 862-byte HTML for all three URLs. This PR has not updated the production alias.