Make comparison controls and room actions readable on phones - #6
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A person running the comparison on a phone could lose part of the model/count controls or the completion badge, and a room participant could lose the Invite button beyond the header. This change wraps existing control groups and room actions and keeps the complete numeric fields and status visible in the tested views.
Only layout classes and the comparison control group's accessible name change in the two existing owners. Playback, room handlers, state reducers, shared primitives, provider configuration and dependencies remain unchanged. The new HANDOFF provides keyless setup and the exact limits of the retained evidence.
Actual before and after
Verification
npm run doctor,npm run proofandnpm run buildpass. Doctor covers server/client/Convex types and 56 citations; proof covers 55 tests in 9 files plus the separate target-12 CLI smoke..log.txtso normal Git publication retains them without changing ignore policy.Limits and rollback
The first after-pass had an insufficient interior-only control check; later forward/reverse Tab failures are retained. Ordinary wrapping removes the horizontal focus-scroll dependency without adding focus handlers.
Eleven final captures still contain off-viewport descendants in other detail regions. Selected-option ellipsis, detailed panes, short-height reading, full visual/accessibility grades, native devices/zoom, audible speech/microphone, actual provider/agent execution, hosted Convex and durable restart remain unverified. The baseline has three high development-tool package entries; this layout PR changes no dependencies. The local server still binds an unspecified host.
This is a reversible layout/documentation change with no schema migration. Revert the commit to roll it back. No production interaction or deployment claim is made.