Preserve desktop Account labels in downloaded workbooks - #253
Merged
Conversation
A reviewer saw five Account labels in the grid but received blank workbook cells. Both canonical export branches now read the existing __label field. Changed areas: - src: correct the two existing Account field lookups. - tests: reopen real serialized workbooks for current and sibling typed store fixtures. - e2e: retain actual memory-engine downloads across later notes and repeated exports. - HANDOFF: give reproducible commands and distinguish component fixtures, browser proof and limits. - evidence: preserve exact source, files, pixels, command failures and independent judgment. Changed files: - HANDOFF.md - e2e/excel-grid.spec.ts - evidence/desktop-account-20260905/.gitattributes - evidence/desktop-account-20260905/README.md - evidence/desktop-account-20260905/judge/actual-head.bin - evidence/desktop-account-20260905/judge/actual-index.bin - evidence/desktop-account-20260905/judge/actual-refs.bin - evidence/desktop-account-20260905/judge/actual-source.diff - evidence/desktop-account-20260905/judge/actual-status.txt - evidence/desktop-account-20260905/judge/actual-worktrees.bin - evidence/desktop-account-20260905/judge/artifact-bindings.json - evidence/desktop-account-20260905/judge/checks-in-progress.json - evidence/desktop-account-20260905/judge/checks.json - evidence/desktop-account-20260905/judge/closing-custody.json - evidence/desktop-account-20260905/judge/collector-search-failure.txt - evidence/desktop-account-20260905/judge/command-results.json - evidence/desktop-account-20260905/judge/freeze-desktop-account-judge.py.txt - evidence/desktop-account-20260905/judge/handoff-links.json - evidence/desktop-account-20260905/judge/independent-zip-xml.json - evidence/desktop-account-20260905/judge/manifest.json - evidence/desktop-account-20260905/judge/retained-failure-bindings.json - evidence/desktop-account-20260905/judge/review-desktop-account.py.txt - evidence/desktop-account-20260905/judge/source-bindings.json - evidence/desktop-account-20260905/judge/source-trace.json - evidence/desktop-account-20260905/judge/viewed-pixels.json - evidence/desktop-account-20260905/manifest.json - evidence/desktop-account-20260905/operator/account-browser-suite.command.json - evidence/desktop-account-20260905/operator/account-browser-suite.log - evidence/desktop-account-20260905/operator/account-convex-typecheck.command.json - evidence/desktop-account-20260905/operator/account-convex-typecheck.log - evidence/desktop-account-20260905/operator/account-design-audit.command.json - evidence/desktop-account-20260905/operator/account-design-audit.log - evidence/desktop-account-20260905/operator/account-final-build.command.json - evidence/desktop-account-20260905/operator/account-final-build.log - evidence/desktop-account-20260905/operator/account-final-fixture-knockout.command.json - evidence/desktop-account-20260905/operator/account-final-fixture-knockout.log - evidence/desktop-account-20260905/operator/account-final-scenarios.command.json - evidence/desktop-account-20260905/operator/account-final-scenarios.log - evidence/desktop-account-20260905/operator/account-matched-after.command.json - evidence/desktop-account-20260905/operator/account-matched-after.log - evidence/desktop-account-20260905/operator/account-scenarios-after-02.command.json - evidence/desktop-account-20260905/operator/account-scenarios-after-02.log - evidence/desktop-account-20260905/operator/account-scenarios-after-03.command.json - evidence/desktop-account-20260905/operator/account-scenarios-after-03.log - evidence/desktop-account-20260905/operator/account-scenarios-after.command.json - evidence/desktop-account-20260905/operator/account-scenarios-after.log - evidence/desktop-account-20260905/operator/account-scenarios-before-02.command.json - evidence/desktop-account-20260905/operator/account-scenarios-before-02.log - evidence/desktop-account-20260905/operator/account-scenarios-before.command.json - evidence/desktop-account-20260905/operator/account-scenarios-before.log - evidence/desktop-account-20260905/operator/account-typecheck.command.json - evidence/desktop-account-20260905/operator/account-typecheck.log - evidence/desktop-account-20260905/operator/after-source-bindings.json - evidence/desktop-account-20260905/operator/after/Q3_variance.xlsx - evidence/desktop-account-20260905/operator/after/change-boundary.md.txt - evidence/desktop-account-20260905/operator/after/change-boundary.png - evidence/desktop-account-20260905/operator/after/desktop-memory-1440-downloaded.html.txt - evidence/desktop-account-20260905/operator/after/desktop-memory-1440-downloaded.json - evidence/desktop-account-20260905/operator/after/desktop-memory-1440-downloaded.png - evidence/desktop-account-20260905/operator/after/desktop-memory-1440-entry.html.txt - evidence/desktop-account-20260905/operator/after/desktop-memory-1440-entry.json - evidence/desktop-account-20260905/operator/after/desktop-memory-1440-entry.png - evidence/desktop-account-20260905/operator/after/desktop-memory-1440-later-download.html.txt - evidence/desktop-account-20260905/operator/after/desktop-memory-1440-later-download.json - evidence/desktop-account-20260905/operator/after/desktop-memory-1440-later-download.png - evidence/desktop-account-20260905/operator/after/desktop-memory-1440-sample.html.txt - evidence/desktop-account-20260905/operator/after/desktop-memory-1440-sample.json - evidence/desktop-account-20260905/operator/after/desktop-memory-1440-sample.png - evidence/desktop-account-20260905/operator/after/report.json - evidence/desktop-account-20260905/operator/after/review-2-Q3_variance.xlsx - evidence/desktop-account-20260905/operator/after/server.log - evidence/desktop-account-20260905/operator/after/ui-to-workbook.json - evidence/desktop-account-20260905/operator/before-browser.command.json - evidence/desktop-account-20260905/operator/before-browser.log - evidence/desktop-account-20260905/operator/before-build.command.json - evidence/desktop-account-20260905/operator/before-build.log - evidence/desktop-account-20260905/operator/before-current-dist-bindings.json - evidence/desktop-account-20260905/operator/before-design-manifest.command.json - evidence/desktop-account-20260905/operator/before-design-manifest.log - evidence/desktop-account-20260905/operator/before-head.txt - evidence/desktop-account-20260905/operator/before-refs.txt - evidence/desktop-account-20260905/operator/before-status.txt - evidence/desktop-account-20260905/operator/before-worktrees.txt - evidence/desktop-account-20260905/operator/before/Q3_variance.xlsx - evidence/desktop-account-20260905/operator/before/change-boundary.md.txt - evidence/desktop-account-20260905/operator/before/change-boundary.png - evidence/desktop-account-20260905/operator/before/desktop-memory-1440-downloaded.html.txt - evidence/desktop-account-20260905/operator/before/desktop-memory-1440-downloaded.json - evidence/desktop-account-20260905/operator/before/desktop-memory-1440-downloaded.png - evidence/desktop-account-20260905/operator/before/desktop-memory-1440-entry.html.txt - evidence/desktop-account-20260905/operator/before/desktop-memory-1440-entry.json - evidence/desktop-account-20260905/operator/before/desktop-memory-1440-entry.png - evidence/desktop-account-20260905/operator/before/desktop-memory-1440-sample.html.txt - evidence/desktop-account-20260905/operator/before/desktop-memory-1440-sample.json - evidence/desktop-account-20260905/operator/before/desktop-memory-1440-sample.png - evidence/desktop-account-20260905/operator/before/report.json - evidence/desktop-account-20260905/operator/before/server.log - evidence/desktop-account-20260905/operator/before/ui-to-workbook.json - evidence/desktop-account-20260905/operator/bind-after-source.py.txt - evidence/desktop-account-20260905/operator/browser-suite/command.json - evidence/desktop-account-20260905/operator/browser-suite/playwright.json - evidence/desktop-account-20260905/operator/browser-suite/playwright.stderr.log - evidence/desktop-account-20260905/operator/browser-suite/prior-hardcoded-screenshot.png - evidence/desktop-account-20260905/operator/browser-suite/results/.last-run.json - evidence/desktop-account-20260905/operator/browser-suite/results/excel-grid-a-reviewer-reop-1660a--edits-and-repeated-exports-chromium/attachments/review-1-xlsx-8d322e6991638bbf510ae3e72dba7d7b1229f8bd.xlsx - evidence/desktop-account-20260905/operator/browser-suite/results/excel-grid-a-reviewer-reop-1660a--edits-and-repeated-exports-chromium/attachments/review-2-xlsx-d8bd07bada085ad796bb49244ecd789b4ea58285.xlsx - evidence/desktop-account-20260905/operator/browser-suite/results/excel-grid-a-reviewer-reop-1660a--edits-and-repeated-exports-chromium/desktop-account-current-export.png - evidence/desktop-account-20260905/operator/browser-suite/results/excel-grid-a-reviewer-reop-1660a--edits-and-repeated-exports-chromium/review-1-Q3_variance.xlsx - evidence/desktop-account-20260905/operator/browser-suite/results/excel-grid-a-reviewer-reop-1660a--edits-and-repeated-exports-chromium/review-2-Q3_variance.xlsx - evidence/desktop-account-20260905/operator/browser-suite/server.log - evidence/desktop-account-20260905/operator/browser-suite/uploaded-workbook-shared-grid.png - evidence/desktop-account-20260905/operator/custody-environment-wording-addendum.json - evidence/desktop-account-20260905/operator/custody.json - evidence/desktop-account-20260905/operator/final-commands.json - evidence/desktop-account-20260905/operator/final-dist-bindings.json - evidence/desktop-account-20260905/operator/final-head.txt - evidence/desktop-account-20260905/operator/final-refs.txt - evidence/desktop-account-20260905/operator/final-source.diff - evidence/desktop-account-20260905/operator/final-status.txt - evidence/desktop-account-20260905/operator/final-worktrees.txt - evidence/desktop-account-20260905/operator/freeze-attempt-01.error.txt - evidence/desktop-account-20260905/operator/freeze-final.py.txt - evidence/desktop-account-20260905/operator/freeze.json - evidence/desktop-account-20260905/operator/freeze.py.txt - evidence/desktop-account-20260905/operator/handoff-link-check.json - evidence/desktop-account-20260905/operator/installed-bindings.json - evidence/desktop-account-20260905/operator/knockout-final-Artifact.tsx.txt - evidence/desktop-account-20260905/operator/knockout-final-artifactXlsxExport.test.ts.txt - evidence/desktop-account-20260905/operator/knockout-regressed-Artifact.tsx.txt - evidence/desktop-account-20260905/operator/knockout-source-bindings.json - evidence/desktop-account-20260905/operator/manifest.json - evidence/desktop-account-20260905/operator/observe-after.mjs.txt - evidence/desktop-account-20260905/operator/observe-before.mjs.txt - evidence/desktop-account-20260905/operator/prepare-after-probe.py.txt - evidence/desktop-account-20260905/operator/preserve-build-and-knockout.py.txt - evidence/desktop-account-20260905/operator/prior-dist-bindings.json - evidence/desktop-account-20260905/operator/raw-workbook-xml-check.json - evidence/desktop-account-20260905/operator/run-browser-suite.mjs.txt - evidence/desktop-account-20260905/operator/run-command.py.txt - evidence/desktop-account-20260905/operator/source-after/HANDOFF.md.txt - evidence/desktop-account-20260905/operator/source-after/e2e/excel-grid.spec.ts.txt - evidence/desktop-account-20260905/operator/source-after/src/ui/panels/Artifact.tsx.txt - evidence/desktop-account-20260905/operator/source-after/tests/artifactXlsxExport.test.ts.txt - evidence/desktop-account-20260905/operator/source-before/HANDOFF.md.txt - evidence/desktop-account-20260905/operator/source-before/e2e/excel-grid.spec.ts.txt - evidence/desktop-account-20260905/operator/source-before/package-lock.json - evidence/desktop-account-20260905/operator/source-before/package.json - evidence/desktop-account-20260905/operator/source-before/src/app/styles.css.txt - evidence/desktop-account-20260905/operator/source-before/src/ui/panels/Artifact.tsx.txt - evidence/desktop-account-20260905/operator/source-before/src/ui/workArtifacts/xlsxDownload.ts.txt - evidence/desktop-account-20260905/operator/source-before/tests/artifactXlsxExport.test.ts.txt - evidence/desktop-account-20260905/operator/source-normalization.json - evidence/desktop-account-20260905/original-inventory.json - evidence/desktop-account-20260905/raw-copy-map.json - evidence/desktop-account-20260905/review/E6f_NODEROOM_DESKTOP_ACCOUNT_FINAL_JUDGE.json - evidence/desktop-account-20260905/review/E6f_NODEROOM_DESKTOP_ACCOUNT_FINAL_JUDGE.md.txt - evidence/desktop-account-20260905/review/E6f_NODEROOM_DESKTOP_ACCOUNT_REPAIR_RECEIPT.json - evidence/desktop-account-20260905/review/E6f_NODEROOM_DESKTOP_ACCOUNT_REPAIR_RECEIPT.md.txt - evidence/desktop-account-20260905/verify.py - src/ui/panels/Artifact.tsx - tests/artifactXlsxExport.test.ts Verification: - Normal build including root TypeScript, Convex TypeScript, design audit and10 affected scenarios passed. - Three ordinary browser cases passed under unchanged30second budgets; actual downloaded XLSX files reopened independently. - Exactly five Account values restored; other25values and30styles preserved. Later exports change E2; earlier files stay exact. - Two-lookup knockout fails both label scenarios. Independent source22/22 and publication18/18 checks pass. - All161 staged blobs match the frozen candidate. Python portable verifier passes. Limits: - Both component cases use a typed mocked store and replaced download boundary. Only current canonical sheet has this repair's actual memory-engine browser journey. - Seven large original archives/index inventories remain in local custody and are not available to the portable verifier. - Fallback fonts, one desktop width, bounded repeats; no full visual/device/performance/load/production grade. - Inherited notebook failures, Windows native Excel deadline, nightly credential and development advisory remain open. - Shared CI and integration are subsequent checks; no native Office or provider call in this slice.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Scaffold Handoff — For Your Coding Agent
Immutability CheckMode: advisory ✅ No immutable files were modified in this branch. Changed Files
Needs Adversarial Review — Do NOT Apply YetThese proposals passed the reject check but have not been approved by
Safety Boundary
Immutable files (never modify):
Scaffold files (safe to modify):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reviewer could see five Account labels in the desktop Q3 variance grid but receive blank cells in the downloaded XLSX. Both canonical export branches now read the existing
__labelfield. The visible grid and shared export transport keep their existing behavior.Current- and sibling-sheet component tests reopen serialized workbooks across repeated edits and duplicate activation. Both use a typed mocked store and replaced browser download boundary. The ordinary memory-engine browser test saves actual files for the current canonical sheet; a later note changes the new export without changing the earlier file.
The portable evidence packet contains before/after XLSX, screenshots, original failure logs and independent source/publication judgments. Its verifier binds included raw files and current source identities. Seven large original build/index inventories stay in local custody and are explicitly outside portable verification.
Validation: normal build including root TypeScript, Convex TypeScript, design audit, 10 affected scenarios and 3 unchanged-budget browser cases pass. Independent ZIP/XML inspection confirms exactly five restored labels, the other 25 values and all 30 styles preserved. Restoring the two old lookups fails both label scenarios. Independent source 22/22 and publication 18/18 checks pass; all 161 committed blobs match the frozen candidate and the actual-head commit check passes. Normal shared checks remain required.
Existing notebook failures, Windows native Excel timeout, missing nightly credential and development advisory remain open. This local memory-engine proof does not certify native Office, provider calls, production workbook behavior or full visual/responsive/accessibility/performance grades.