cleanup: delete unmounted legacy components across UI page flows - #250
Merged
Merged
Conversation
Every deletion grep-verified (zero runtime importers), per the 11-agent
surface audit + manual re-verification:
- MobileScreens: dead Room/Coach/ExtractCard screens + their toJSON/
highlightJSON helpers (~330 loc); MobileChat: unmounted Composer (the
live path is MobileApp's inline composer); dead scopeTable re-exports;
ExtractCard-only CSS block in mobile.css
- panels/Artifact.tsx: unmounted Research + ResearchLegacy (renders via
GenericSheet since the :514 comment; helpers kept — GenericSheet uses them)
- trace: TraceStorybook + LoopRewardPanel + their orphan test (classic
tested-but-never-constructed; proofloopArtifacts' renderTraceStorybook
is an unrelated local string renderer and is untouched)
- Chat.tsx: dead coach prop (Coach is a RoomShell mode since the split)
- storyTape.ts: dead Actor/MEMBERS/AGENTS/LandingEvent/EVENT_TAPE exports
- primitives/designSystem: 6 dead exports + their now-orphaned CSS blocks
- styles.css: 6 zero-consumer namespaces (r-excel-*, r-sidebar-*,
r-activity-*, r-pill-auto, r-feature, r-beat-desc)
- LeftRail: {false && ...} dead JSX (dup binder-review-queue testid) +
voided sub helper
- stale-comment hygiene (ExcelGridSheet references), .gitignore dedupe,
archived the obsolete kimi handoff (targets a component deleted in d022d42)
Test-floor repairs landed with measurements:
- githubActionsRuntimePins: expected ref updated for the node-platform ->
NodeKit repo rename (5de0508); same immutable SHA pin
- proofloop longrun/dogfood tests: root cause was re-parsing a grown ~15MB
.proofloop longrun state.json per plan build (2.54s measured); readJson
now memoized by path+mtime; per-file timeout 5s -> 30s with the numbers
in-file
- nodebookWorkspaceProjection: 60s -> 180s with cold/warm measurements
(70.95s cold transform of six lazy renderer plugins, ~7s warm)
NOT deleted (kept-legacy, documented): split-pane kind-tab strip (e2e-pinned),
legacy Note editor (docs/STACK.md:13), agent-operation-stream fallback (live
safety net), notebook envelope lane (needs a wire-or-collapse decision),
initials() 4x dedup REFUTED (implementations differ on separators/single names).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- restore commit/createElement/deleteElement CAS helpers (ResearchLegacy ends 15 lines earlier than the audit's range; the splice swallowed them) - restore ExtractCard + toJSON/highlightJSON + extract CSS: audit's zero-consumer claim REFUTED — SampleCapture renders it (MobileScreens:221) - drop freshnessLabel/freshnessClass (only Research used them), orphaned scopeTable fn + ScopeLane type in MobileSheets, unused MobileChat imports - tests: the vi.setConfig insertion had silently failed; now actually applied Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Scaffold Handoff — For Your Coding Agent
Immutability CheckMode: advisory ✅ No immutable files were modified in this branch. Changed Files
Needs Adversarial Review — Do NOT Apply YetThese proposals passed the reject check but have not been approved by
Safety Boundary
Immutable files (never modify):
Scaffold files (safe to modify):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wave 1 of the end-to-end UI cleanup: ~1,300 lines of grep-verified dead/legacy code deleted across the page flows (mobile dead screens, unmounted Research renderers, tested-but-never-constructed trace panels, dead exports/CSS namespaces), plus test-floor repairs with measurements (NodeKit workflow-rename pin, proofloop 15MB-state memoization, NodeBook cold-transform timeout re-bound).
Evidence & receipts
🤖 Generated with Claude Code