Skip to content

fix: discover review boundaries in generated applications - #24

Merged
HomenShum merged 1 commit into
mainfrom
codex/nodeproof-consumer-discovery-20260905
Sep 5, 2026
Merged

fix: discover review boundaries in generated applications#24
HomenShum merged 1 commit into
mainfrom
codex/nodeproof-consumer-discovery-20260905

Conversation

@HomenShum

Copy link
Copy Markdown
Owner

Summary

A generated NodeKit application already exposes an explicit proposal review boundary, but NodeProof's setup scan missed it because it did not scan apps/public or recognize data-nodekit-review-boundary. Add those roots and that specific marker namespace to existing discovery, while preserving the 800-file budget and dependency/build exclusions. Ordinary IDs and dynamic artifact attributes remain excluded.

Add an adoption guide for an actual application with a pinned local package, real gate commands, persisted failure and fresh-process recovery. Doctor remains configuration discovery, not browser or CI certification.

Validation

  • Independent normal install/build and 265 tests across 28 suites pass; all 60 generated dist files match the reviewed source export.
  • Eight additional scanner scenarios cover existing namespaces, ordinary-ID exclusion, repeated scans, removal/restoration and the 805-file boundary.
  • The installed package's 106 files match the reviewed tarball/source. A real NodeKit 53348d6 consumer passes its documented install/compile/demo/gate sequence, retains an intentional failed check across cached reads and resume, and recovers after exact restoration.
  • Actual 390/1440 browser journeys prove the discovered marker is visible and rejection/approval preserve and advance the displayed artifact version respectively. This is not a complete UI grade.

The separate NodeKit consumer still lacks its promised machine-readable artifact identity fields and displays an empty error strip after success. Those inherited template requirements are recorded for upstream repair; this PR does not certify complete consumer interoperability, host activation or production operation.

@vercel

vercel Bot commented Sep 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
proofloop Ready Ready Preview Sep 5, 2026 3:11am UTC

Request Review

@HomenShum
HomenShum marked this pull request as ready for review September 5, 2026 03:15
@HomenShum
HomenShum merged commit e45f90f into main Sep 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant