fix: discover review boundaries in generated applications - #24
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
HomenShum
marked this pull request as ready for review
September 5, 2026 03:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A generated NodeKit application already exposes an explicit proposal review boundary, but NodeProof's setup scan missed it because it did not scan
apps/publicor recognizedata-nodekit-review-boundary. Add those roots and that specific marker namespace to existing discovery, while preserving the 800-file budget and dependency/build exclusions. Ordinary IDs and dynamic artifact attributes remain excluded.Add an adoption guide for an actual application with a pinned local package, real gate commands, persisted failure and fresh-process recovery. Doctor remains configuration discovery, not browser or CI certification.
Validation
The separate NodeKit consumer still lacks its promised machine-readable artifact identity fields and displays an empty error strip after success. Those inherited template requirements are recorded for upstream repair; this PR does not certify complete consumer interoperability, host activation or production operation.