Preserve runtime completion and packaged CLI contracts - #6
Merged
Conversation
Integrate the preserved event and Pi adapter seam onto current main. Distinguish terminal errors, aborts and truncation from natural completion, retain reported usage and label model-rate costs as estimates. Include both CLI templates and optional-peer ESM/type entrypoints. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A caller needs to know whether an answer actually finished. The preserved Pi adapter treated fulfilled SDK error messages as success. This change integrates the preserved runtime/event seam onto current main and marks completion only for a natural stop without outstanding tools. Terminal errors and aborts reject with typed errors and reported usage; rejected text callbacks cancel the owned stream. Model-rate costs are explicitly estimates.
The package adds optional-peer ESM/type entrypoints and includes both existing CLI scaffold templates. Root/runtime imports work without Pi. README documents the scoped package, exact tested SDK version, and each scaffold's first install command. Existing UI, graph, tours, historical receipts and security overrides are retained.
Validation independently reviewed at the exact twelve changed paths:
Limits: the full development install still reports nine advisories (three moderate, five high, one critical). Convex was not configured, live provider checks skipped, and the official Omnigent CLI was absent locally. The separate npm
omniagentprobe does not prove the official CLI. Provider availability/billing, UI quality, accessibility, sustained production capacity and complete product readiness remain unproved.First shared PR CI passed at exact head
8a64fccb50d369b00a1dac418a3e7ba7d522ebf2and synthetic mergef4fee537b9bd9bf9cf7b5c2930c01282ee97abf6(the same reviewed tree). NodeAgent CI ran 57 tests, types/library/UI builds, the existing checks, production audit zero and the temporary walkthrough render/unchanged-media guard on Ubuntu with Node 22.23.2. Full install still reports the nine development advisories. Convex was not configured and live-provider checks skipped. The dedicated official Omnigent probe passed--helpandrun --helpthroughuv tool run --python 3.12 omnigent; the generic prepush PATH probe still found no globally installed official CLI. These are distinct observations, and no official agent/provider execution is claimed. Conformance and GitGuardian passed. Local packed-consumer proof remains separately bound; shared CI did not rerun those custom consumers.