Skip to content

Preserve runtime completion and packaged CLI contracts - #6

Merged
HomenShum merged 1 commit into
mainfrom
codex/nodeagent-runtime-salvage-20260907
Sep 7, 2026
Merged

Preserve runtime completion and packaged CLI contracts#6
HomenShum merged 1 commit into
mainfrom
codex/nodeagent-runtime-salvage-20260907

Conversation

@HomenShum

@HomenShum HomenShum commented Sep 7, 2026

Copy link
Copy Markdown
Owner

A caller needs to know whether an answer actually finished. The preserved Pi adapter treated fulfilled SDK error messages as success. This change integrates the preserved runtime/event seam onto current main and marks completion only for a natural stop without outstanding tools. Terminal errors and aborts reject with typed errors and reported usage; rejected text callbacks cancel the owned stream. Model-rate costs are explicitly estimates.

The package adds optional-peer ESM/type entrypoints and includes both existing CLI scaffold templates. Root/runtime imports work without Pi. README documents the scoped package, exact tested SDK version, and each scaffold's first install command. Existing UI, graph, tours, historical receipts and security overrides are retained.

Validation independently reviewed at the exact twelve changed paths:

  • Real SDK 0.80.10 targeted scenarios: motivating baseline 10 failed/6 passed, corrected 16 passed; source scenarios include concurrent and repeated streams, aborts and rejected callbacks.
  • Normal local check passed once: 57 tests in nine files, typecheck, library/UI builds, frame/durable/SQLite checks, both scaffold smokes, three tours/36 steps/11 citations, and production audit with zero findings.
  • Actual packed peer-free and exact-peer consumers passed. Both templates match all 15 chat and 11 dashboard source files. The peer consumer exercised ten concurrent and ten repeated outcomes through real SDK stream primitives with injected local ports and zero provider fetches.
  • Final package has 37 members. Only README differs from the executed consumer package; the other 36 members are byte-exact. The final README was separately reviewed; no final-package reinstall is claimed.
  • Original primary source/branch and old candidate installation remain preserved. No npm publication or Convex deployment.

Limits: the full development install still reports nine advisories (three moderate, five high, one critical). Convex was not configured, live provider checks skipped, and the official Omnigent CLI was absent locally. The separate npm omniagent probe does not prove the official CLI. Provider availability/billing, UI quality, accessibility, sustained production capacity and complete product readiness remain unproved.

First shared PR CI passed at exact head 8a64fccb50d369b00a1dac418a3e7ba7d522ebf2 and synthetic merge f4fee537b9bd9bf9cf7b5c2930c01282ee97abf6 (the same reviewed tree). NodeAgent CI ran 57 tests, types/library/UI builds, the existing checks, production audit zero and the temporary walkthrough render/unchanged-media guard on Ubuntu with Node 22.23.2. Full install still reports the nine development advisories. Convex was not configured and live-provider checks skipped. The dedicated official Omnigent probe passed --help and run --help through uv tool run --python 3.12 omnigent; the generic prepush PATH probe still found no globally installed official CLI. These are distinct observations, and no official agent/provider execution is claimed. Conformance and GitGuardian passed. Local packed-consumer proof remains separately bound; shared CI did not rerun those custom consumers.

Integrate the preserved event and Pi adapter seam onto current main.
Distinguish terminal errors, aborts and truncation from natural completion,
retain reported usage and label model-rate costs as estimates.
Include both CLI templates and optional-peer ESM/type entrypoints.

Co-Authored-By: Codex <noreply@openai.com>
@HomenShum
HomenShum merged commit 54dcf10 into main Sep 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant