-
Notifications
You must be signed in to change notification settings - Fork 3.5k
tui: align typed config and schema with the live value spaces #5843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7b13b57
091f133
01ec884
9a29726
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -239,8 +239,9 @@ const INLINE_DIFFS: &[SettingOption] = &[ | |
| ]; | ||
|
|
||
| const STATUS_INDICATOR: &[SettingOption] = &[ | ||
| // `whale` is retired: load migrates whale | 🐳 | 🐋 to the typographic | ||
| // mark, so the editor no longer offers it. | ||
| SettingOption::new("cw", "ConfigChoiceStatusCw", ""), | ||
| SettingOption::new("whale", "ConfigChoiceStatusWhale", ""), | ||
| SettingOption::new("dots", "ConfigChoiceStatusDots", ""), | ||
| SettingOption::new("off", "ConfigValueOff", ""), | ||
| ]; | ||
|
|
@@ -284,6 +285,11 @@ const WORK_SURFACE_PLACEMENT: &[SettingOption] = &[ | |
| "ConfigChoicePlacementTop", | ||
| "ConfigChoiceDetailPlacementTop", | ||
| ), | ||
| SettingOption::new( | ||
| "bottom", | ||
| "ConfigChoicePlacementBottom", | ||
| "ConfigChoiceDetailPlacementBottom", | ||
| ), | ||
| SettingOption::new( | ||
| "left", | ||
| "ConfigChoicePlacementLeft", | ||
|
|
@@ -298,6 +304,8 @@ const WORK_SURFACE_PLACEMENT: &[SettingOption] = &[ | |
| ]; | ||
|
|
||
| const RAIL_PANEL: &[SettingOption] = &[ | ||
| // The dock's own grammar is lowercase nouns, so the panels the classic | ||
| // sidebar never named ride on their raw value (`RailPanel::title`). | ||
| SettingOption::new( | ||
| "tasks", | ||
| "ConfigChoiceRailTasks", | ||
|
|
@@ -308,16 +316,16 @@ const RAIL_PANEL: &[SettingOption] = &[ | |
| "ConfigChoiceRailAgents", | ||
| "ConfigChoiceDetailRailAgents", | ||
| ), | ||
| SettingOption::new("background", "", ""), | ||
| SettingOption::new("files", "", ""), | ||
| SettingOption::new("notepad", "", ""), | ||
| SettingOption::new( | ||
| "context", | ||
| "ConfigChoiceRailContext", | ||
| "ConfigChoiceDetailRailContext", | ||
| ), | ||
| SettingOption::new( | ||
| "pinned", | ||
| "ConfigChoiceRailPinned", | ||
| "ConfigChoiceDetailRailPinned", | ||
| ), | ||
| SettingOption::new("git", "", ""), | ||
| SettingOption::new("price", "", ""), | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [INFO] New rail panel schema entries use empty label and hint strings
|
||
| ]; | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid empty label/hint strings for the newly exposed rail panels. Either add explicit locale/MessageId entries for background/files/notepad/git/price, or add a test that proves the empty-label fallback displays the raw |
||
| /// Rail tab ids. | ||
|
|
@@ -681,7 +689,7 @@ pub const SETTINGS_SCHEMA: &[SettingDef] = &[ | |
| def( | ||
| "work_surface_placement", | ||
| SettingKind::Enum(WORK_SURFACE_PLACEMENT), | ||
| "left", | ||
| "bottom", | ||
| ui( | ||
| TAB_WORK, | ||
| "sidebar", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[WARNING] New rail panel schema entries have empty display strings
RAIL_PANEL introduces background/files/notepad/git/price as SettingOption::new with empty title and detail IDs. If the settings UI renders the stored title/detail IDs directly, these five entries will show blank labels or descriptions rather than RailPanel::title. Confirm the UI has an empty-ID fallback or add MessageId/localized strings for parity with the other rail options.