Dev - #5
Merged
Merged
Dev#5
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the public API surface of the logger package by adding a simple logger registry (“builder”) module and exporting it from the package entrypoint, while also aligning configuration naming in the test harness and refreshing tooling/dependencies.
Changes:
- Add
src/builder.tswithcreateLogger/getLogger/hasLoggerhelper functions and re-export it fromsrc/index.ts. - Fix logger options casing in
test/main.ts(Transformers→transformers) to match the actualLoggerOptionsshape. - Update package version and development toolchain (switch
typechecktotsc, bump ESLint/TypeScript/tooling versions, updatebun.lock).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/main.ts | Aligns logger instantiation options with the actual LoggerOptions API (transformers). |
| src/index.ts | Exposes the new builder/registry API as part of the package entrypoint. |
| src/builder.ts | Introduces a module-level logger registry with create/get/has helpers. |
| package.json | Bumps version and updates typecheck + dev tool dependency versions. |
| bun.lock | Updates lockfile to reflect the dependency/tooling version bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+6
to
+10
| export function createLogger(name: string, options: LoggerOptions): Logger { | ||
| const logger = new Logger(options) | ||
| loggers.set(name, logger) | ||
| return logger | ||
| } |
Comment on lines
+6
to
+9
| export function createLogger(name: string, options: LoggerOptions): Logger { | ||
| const logger = new Logger(options) | ||
| loggers.set(name, logger) | ||
| return logger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.