Skip to content

🧪 [testing improvement] Add missing username validation edge case tests #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
is0692vs merged 2 commits into from
Mar 21, 2026
Merged

🧪 [testing improvement] Add missing username validation edge case tests #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b711fdc
🧪 Add missing username validation edge case tests
google-labs-jules[bot] Mar 20, 2026
efd02a2
test: tighten username validator review fixes
is0692vs Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/lib/__tests__/validators.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,23 @@ describe("isValidGitHubUsername", () => {
it("SQLインジェクション的な文字列は無効", () => {
expect(isValidGitHubUsername("'; DROP TABLE users; --")).toBe(false);
});

it("マルチバイト文字（日本語や絵文字）を含むユーザー名は無効", () => {
expect(isValidGitHubUsername("テスト")).toBe(false);
expect(isValidGitHubUsername("user😀")).toBe(false);
expect(isValidGitHubUsername("déjà-vu")).toBe(false);
});

it("空白文字や制御文字を含むユーザー名は無効", () => {
expect(isValidGitHubUsername(" testuser")).toBe(false);
expect(isValidGitHubUsername("testuser ")).toBe(false);
expect(isValidGitHubUsername("test\nuser")).toBe(false);
expect(isValidGitHubUsername("test\tuser")).toBe(false);
expect(isValidGitHubUsername("test\0user")).toBe(false);
});

it("極端に長い文字列は無効 (長さ上限の確認)", () => {
expect(isValidGitHubUsername("a".repeat(1000))).toBe(false);
});

});
Loading