Skip to content

fix(security): sanitize external links in ProfileCard and ReposCard t…#105

Merged
is0692vs merged 1 commit intomainfrom
fix/xss-vulnerability-profile-card-11234692421722078261
Mar 21, 2026
Merged

fix(security): sanitize external links in ProfileCard and ReposCard t…#105
is0692vs merged 1 commit intomainfrom
fix/xss-vulnerability-profile-card-11234692421722078261

Conversation

@is0692vs
Copy link
Contributor

…o prevent XSS

  • Implement sanitizeUrl in src/lib/validators.ts to strictly allow http/https and handle protocol-less URLs.
  • Apply sanitizeUrl to profile.blog and repo.url in ProfileCard.tsx and ReposCard.tsx.
  • Add unit tests for sanitizeUrl in src/lib/__tests__/validators.test.ts.

…o prevent XSS

- Implement `sanitizeUrl` in `src/lib/validators.ts` to strictly allow http/https and handle protocol-less URLs.
- Apply `sanitizeUrl` to `profile.blog` and `repo.url` in `ProfileCard.tsx` and `ReposCard.tsx`.
- Add unit tests for `sanitizeUrl` in `src/lib/__tests__/validators.test.ts`.

Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
github-user-summary Building Building Preview Mar 20, 2026 7:07am

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a critical security improvement by integrating URL sanitization across components displaying external links. The primary goal is to mitigate potential XSS attacks by ensuring that all user-provided or external URLs are safe before being rendered in the UI. This change enhances the application's robustness against malicious link injections, making it more secure for users.

Highlights

  • Security Enhancement: Implemented a new sanitizeUrl utility function to prevent Cross-Site Scripting (XSS) vulnerabilities by strictly validating and sanitizing external links.
  • URL Sanitization Logic: The sanitizeUrl function ensures that only http and https protocols are allowed, automatically prepends https:// to protocol-less URLs, and blocks malicious protocols like javascript:, data:, or vbscript: by replacing them with a '#' fallback.
  • Application of Sanitization: Applied the sanitizeUrl function to profile.blog links in ProfileCard.tsx and repo.url links in both ProfileCard.tsx and ReposCard.tsx.
  • Unit Testing: Added comprehensive unit tests for the sanitizeUrl function to ensure its correctness and robustness against various URL inputs, including valid, invalid, and malicious ones.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request effectively addresses the security concern of sanitizing external links to prevent XSS vulnerabilities. The sanitizeUrl function is well-implemented, covering various cases including malicious protocols, protocol-relative URLs, and defaulting to HTTPS. The integration into ProfileCard.tsx and ReposCard.tsx is correct, and the added unit tests for sanitizeUrl are comprehensive, ensuring the function's reliability.

@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

Warning

Rate limit exceeded

@is0692vs has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 25 minutes and 40 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: fabf8343-e879-4410-b57d-f01f4b11514c

📥 Commits

Reviewing files that changed from the base of the PR and between 87d145d and 7dd85c2.

📒 Files selected for processing (4)
  • src/components/ProfileCard.tsx
  • src/components/ReposCard.tsx
  • src/lib/__tests__/validators.test.ts
  • src/lib/validators.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/xss-vulnerability-profile-card-11234692421722078261

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@is0692vs
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 21, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@is0692vs is0692vs merged commit 3212eac into main Mar 21, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant