🧪 [Consolidated] CSRF middleware test coverage and log cleanup by is0692vs · Pull Request #182 · Hiroki-org/OpenShelf

is0692vs · 2026-03-22T02:48:17Z

Summary

consolidate CSRF middleware follow-up work into one moderate PR
keep scope limited to CSRF middleware + CSRF tests

Consolidation

This PR consolidates related PRs:

🧹 [Code Health] Remove leftover console.error in CSRF middleware #177

Notes:

Main-merge is intentionally deferred until consolidated review and CI complete.
Included console.error cleanup and catch-block coverage in the same CSRF area.

Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>

google-labs-jules · 2026-03-22T02:48:18Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

vercel · 2026-03-22T02:48:20Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
open-shelf	Ignored		Mar 22, 2026 4:33am

coderabbitai · 2026-03-22T02:48:24Z

Warning

Rate limit exceeded

@is0692vs has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 24 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 869c93d2-2a0f-495d-b447-74b1fe6d2fad

📥 Commits

Reviewing files that changed from the base of the PR and between 0c5719d and b081a52.

📒 Files selected for processing (1)

apps/api/src/routes/__tests__/csrf.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/csrf-catch-block-coverage-4472230607276340976

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist · 2026-03-22T02:48:30Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the API's resilience by introducing a dedicated test for the CSRF middleware's error handling. It specifically validates that the system correctly responds with a 403 Forbidden status when encountering an invalid FRONTEND_URL configuration, thereby preventing potential security vulnerabilities or unexpected behavior in production.

Highlights

Test Coverage: Addressed a testing gap in the CSRF middleware catch block to ensure robust error handling.
Error Condition Simulation: Explicitly added a test case that triggers a URL parsing failure due to a malformed FRONTEND_URL environment variable.
Improved Regression Prevention: Enhanced test coverage for the CSRF middleware, ensuring that any future changes to error handling logic are caught.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds test coverage for the CSRF middleware's error handling path. My review includes a suggestion to improve the robustness of the new test by ensuring mocks are always cleaned up, preventing potential side effects in the test suite.

Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>

codecov · 2026-03-22T03:49:56Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

is0692vs · 2026-03-22T04:31:55Z

メンテナ確認済みです。Botコメント（Codecov / CodeRabbit / Gemini / Jules / Greptile / Vercel）を確認し、現時点で追加対応が必要な指摘はありません。必要な追対応が出た場合はこのPRで反映します。

google-labs-jules · 2026-03-22T04:33:10Z

メンテナ確認済みです。Botコメント（Codecov / CodeRabbit / Gemini / Jules / Greptile / Vercel）を確認し、現時点で追加対応が必要な指摘はありません。必要な追対応が出た場合はこのPRで反映します。

承知いたしました。ご確認いただきありがとうございます。追加の指摘や修正指示がありましたら、引き続き対応させていただきます。

Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>

…-coverage-4472230607276340976

vercel · 2026-03-22T04:52:10Z

Deployment failed with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/hirokis-projects-afd618c7?upgradeToPro=build-rate-limit

google-labs-jules Bot and others added 2 commits March 22, 2026 02:43

🧹 chore: remove leftover console.error in CSRF middleware

708804e

Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>

test(api): add test case for CSRF middleware catch block

892929d

Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>

pull-request-size Bot added the size/S label Mar 22, 2026

gemini-code-assist Bot reviewed Mar 22, 2026

View reviewed changes

Comment thread apps/api/src/routes/__tests__/csrf.test.ts

🧹 fix: add comment to empty catch block to satisfy lint rules

fd8e02e

Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>

greptile-apps Bot reviewed Mar 22, 2026

View reviewed changes

Comment thread apps/api/src/routes/__tests__/csrf.test.ts Outdated

test(api): always restore console.error spy in csrf test

785ca68

pull-request-size Bot added size/M and removed size/S labels Mar 22, 2026

coderabbitai Bot approved these changes Mar 22, 2026

View reviewed changes

google-labs-jules Bot and others added 2 commits March 22, 2026 03:43

test(api): ensure mockRestore is called in finally block for CSRF test

750d075

Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>

🧹 fix(PR): restore console.error for CSRF exceptions

de6a677

Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>

Merge PR #177 into consolidated CSRF test/code-health PR #182

c7144c4

is0692vs changed the title ~~🧪 [API] Add missing test coverage for CSRF middleware catch block~~ 🧪 [Consolidated] CSRF middleware test coverage and log cleanup Mar 22, 2026

is0692vs mentioned this pull request Mar 22, 2026

🧹 [Code Health] Remove leftover console.error in CSRF middleware #177

Closed

google-labs-jules Bot and others added 2 commits March 22, 2026 04:33

test(api): ensure mockRestore is called in finally block for CSRF test

0dab842

Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into test/csrf-catch-block…

b081a52

…-coverage-4472230607276340976

is0692vs merged commit f403678 into main Mar 22, 2026
16 of 18 checks passed

is0692vs deleted the test/csrf-catch-block-coverage-4472230607276340976 branch March 22, 2026 11:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🧪 [Consolidated] CSRF middleware test coverage and log cleanup#182

🧪 [Consolidated] CSRF middleware test coverage and log cleanup#182
is0692vs merged 9 commits intomainfrom
test/csrf-catch-block-coverage-4472230607276340976

is0692vs commented Mar 22, 2026 •

edited

Loading

Uh oh!

google-labs-jules Bot commented Mar 22, 2026

Uh oh!

vercel Bot commented Mar 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Mar 22, 2026 •

edited

Loading

Rate limit exceeded

Uh oh!

gemini-code-assist Bot commented Mar 22, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Mar 22, 2026

Uh oh!

is0692vs commented Mar 22, 2026

Uh oh!

google-labs-jules Bot commented Mar 22, 2026

Uh oh!

vercel Bot commented Mar 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

is0692vs commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Consolidation

Uh oh!

google-labs-jules Bot commented Mar 22, 2026

Uh oh!

vercel Bot commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Uh oh!

gemini-code-assist Bot commented Mar 22, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Mar 22, 2026

Codecov Report

Uh oh!

is0692vs commented Mar 22, 2026

Uh oh!

google-labs-jules Bot commented Mar 22, 2026

Uh oh!

vercel Bot commented Mar 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

is0692vs commented Mar 22, 2026 •

edited

Loading

vercel Bot commented Mar 22, 2026 •

edited

Loading

coderabbitai Bot commented Mar 22, 2026 •

edited

Loading