Fix tracking_freshness TD severity dropout and table wrap-blindness - #370
Open
Hidden-History wants to merge 1 commit into
Open
Hidden-History wants to merge 1 commit into
Hidden-History wants to merge 1 commit into
Conversation
render_td_index enumerated only HIGH/MEDIUM/LOW plus a literal UNSPECIFIED bucket, so an open CRITICAL record was tallied into the Open count but never printed in the breakdown. Rewrite it to use the same residual pattern as render_bugs_index: sum the known buckets and report the remainder as other/unspecified, so no severity value - including one not yet invented - can be silently dropped. _STATUS_TABLE_RE and _SEV_TABLE_RE only matched a table cell on a single line, so a hard-wrapped Status or Severity cell returned no match at all. Both regexes now tolerate a cell wrapped across lines, while refusing to cross into a line that opens a new table row, so a malformed cell missing its closing pipe still cannot swallow the next row.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render_td_indexenumerated only HIGH/MEDIUM/LOW plus a literalUNSPECIFIEDbucket, so an open CRITICAL record was tallied into the Open count but never printed in the breakdown. Rewritten to use the same residual pattern asrender_bugs_index: sum the known buckets and report the remainder asother/unspecified, so no severity value — including one not yet invented — can be silently dropped._STATUS_TABLE_REand_SEV_TABLE_REonly matched a table cell on a single line, so a hard-wrapped Status or Severity cell (e.g.TECH-DEBT-934) returned no match at all. Both regexes now tolerate a cell wrapped across lines, while refusing to cross into a line that opens a new table row, so a malformed cell missing its closing pipe still cannot swallow the next row.Test plan
tests/unit/test_tracking_freshness_skill.py— 184 passed, including 6 new tests (2 wrap-tolerance cases + 1 adjacent-row non-swallow guard for each of Status/Severity, plus 2 CRITICAL/residual breakdown cases for the TD writer)_ai-memory/pov/skills/aim-tracking-freshness/tests/test_tracking_freshness_integration.py— passed_ai-memory/pov/skills/aim-tracking-freshness/tests/test_decision_log_coverage.py— passed_ai-memory/pov/skills/aim-tracking-freshness/tests/test_verify_code_state.py— passedblack,ruff,isortclean on both changed files