Fix numpy.bool_ crash in find_splice_bubbles - #50
Merged
Conversation
Comparing numpy int64 exon coordinates yields numpy.bool_, which Python rejects as a tuple/list index. This broke alternative_splicing_ events, altsplice_test, and coordination_test for any real transcriptome, discovered while re-running the tutorial notebooks against a freshly reconstructed real dataset.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alternative_splicing_events,altsplice_test, andcoordination_testcrashed withTypeError: tuple indices must be integers or slices, not numpy.boolfor real transcriptomes, since comparing numpy int64 exon coordinates yieldsnumpy.bool_, which Python rejects as a sequence index. Fixed by coercing to Pythonboolat the indexing site.Test plan
alternative_splicing_events(1672 events),altsplice_test(690 rows),coordination_test(123 rows) all run cleanlyblack --checkandflake8cleanpython -m build+twine checkpass