Fix die_test crash on isoforms unexpressed in both compared groups (2.1.3) - #48
Merged
Merged
Conversation
Isoforms only covered in samples outside the two groups being tested produced all-zero rows, which made chi2_contingency's expected-frequency table singular. Drop them before the test.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
YalanBi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
die_testcrashed withValueError: expected frequencies has a zero elementwhen a gene's isoform list included isoforms only covered in samples outside the two groups being compared, producing all-zero rows that made the contingency table singular. Such isoforms are now dropped before the test, with returned transcript indices remapped correctly.Test plan
black --checkandflake8cleanpython -m build+twine checkpass