Restore gff3 chromosome name aliasing (2.1.2) - #47
Merged
Conversation
_read_gff_file no longer resolved chromosome name aliases (e.g. RefSeq accessions like NC_000001.11 vs a plain "1"/"chr1" genome FASTA) since the tabix-based get_gff_chrom_dict helper was removed to fix #28. Genes on such files were silently dropped with no warning when filtering against the genome's chromosome names. Restored by recognizing "region" feature lines with a "chromosome" attribute during the same single sequential pass already used for parsing -- no tabix/index requirement reintroduced (still works for arbitrarily large chromosomes, per #28) and no second pass added (still one file read, per #37). Closes #36.
Dependency ReviewThe following issues were found:
License Issues.github/workflows/lint.yml
.github/workflows/tests.yml
OpenSSF Scorecard
Scanned Files
|
checkout v4->v7, setup-python v5->v7, dependency-review-action v4->v5.0.0, codeql-action v3->v4 -- across every workflow, not just tests.yml. Checked checkout's breaking-change notes (safer pull_request_target defaults); none of our workflows use that trigger. Also adds build-check.yml: python -m build + twine check on PRs, so packaging regressions surface at PR time, not just at release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #36:
_read_gff_fileno longer resolved chromosome name aliases (e.g. RefSeq accessions likeNC_000001.11vs a plain1/chr1genome FASTA) since the tabix-basedget_gff_chrom_dicthelper was removed to fix #28. Genes on such files were silently dropped with no warning when filtering against the genome's chromosome names.Restored by recognizing
region-type feature lines with achromosomeattribute during the same single sequential pass already used for parsing. No tabix/index requirement reintroduced, no second pass added.CI: bumped every GitHub Action across all 5 workflows to their current major version (
checkoutv4->v7,setup-pythonv5->v7,dependency-review-actionv4->v5.0.0,codeql-actionv3->v4), and addedbuild-check.yml(python -m build+twine checkon PRs). No CHANGELOG/version bump for this part -- CI-only, no effect on the installed package.Test plan
pytestsuite passes (22 passed), including a new regression test with a minimal RefSeq-style fixture.tbireintroduced) or GFF/GTF import reads the file twice for the progress bar #37 (still single-pass)flake8/blackcleanpython -m build+twine check dist/*pass at 2.1.2