fix(transport): a rate-limited request waits it out and replays - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Le transport ne connaissait pas le 429 : il le remontait comme n'importe quelle erreur d'API. Or les buckets Discord sont petits — cinq écritures par quatre secondes sur certaines routes — donc un appelant qui enchaîne une poignée d'appels en tape un dans le cours normal de son travail.
Cas réel :
Registry.Syncpublie sept commandes à la suite, se prend un 429 à la cinquième et abandonne. Résultat, une commande neuve n'apparaissait jamais dans Discord, silencieusement.Une réponse 429 dit exactement combien de temps attendre. Le transport l'attend et rejoue la requête (jusqu'à 4 fois, jamais plus de 30 s d'attente — au-delà ce n'est plus un bucket mais un quota, et il faut le remonter). Le corps est remarshalé une fois et renvoyé tel quel à chaque tentative.