feat(embeds): surface an embed image's proxy_url - #19
Merged
Conversation
An embed's image url is wherever the picture really lives — for a link preview that is a third-party site. Discord mirrors it on its own CDN and reports that copy as proxy_url. A reader that pins downloads to Discord hosts needs the mirror, not the original, or every previewed image is off-allowlist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmbedMedia.ProxyURL. An embed image'surlpoints at wherever the picture really lives — a third-party site for a link preview. Discord mirrors it and reports the mirror asproxy_url, always on its own CDN. A consumer that pins attachment downloads to Discord hosts needs the mirror; with onlyurlevery previewed image is off-allowlist and silently dropped.Additive field, no signature change.