fix(interactions): resolve the caller in DMs, not just in guilds - #17
Merged
Conversation
Discord carries the invoking user under member.user for a guild interaction and under user for a DM. Interaction only decoded the first, so every permission check reading it saw an empty id in a DM — a populated allowlist denied even its own owner there. Add the user field, and UserID() to read whichever one Discord filled in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord carries the invoking user under
member.userfor a guild interaction and underuserfor a DM.Interactiononly decoded the first, so any permission check reading it saw an empty id in a DM — a populated allowlist denied even its own owner there.userfield toInteractionUserID(), which reads whichever field Discord filled inFound while reviewing the owner-bound Discord gateway, which follows its operator into DMs.