feat(threads): private threads and thread membership - #16
Merged
Conversation
Start opens a thread off a message, which is a public trace in the channel. A job an operator wants kept to themselves needs the other shape: a thread created off the channel, typed private, with invitable false so members cannot pull others in. It is invisible until someone is added to it, so AddMember is what makes one usable by a person rather than only by the bot that opened it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Threads().Startopens a thread off a message, so the channel carries a visible "thread started" trace. A job an operator wants kept to themselves needs the other shape.What
StartPrivate(ctx, channelID, name)—POST /channels/{id}/threadswithtype: 12,invitable: false, 24 h auto-archive. No parent message, so nothing appears in the channel.AddMember(ctx, threadID, userID)—PUT /channels/{id}/thread-members/{user}. A private thread is invisible until members are added, so this is what makes one usable by a person.Visibility is Discord's: invited members, the bot, and moderators holding
MANAGE_THREADS. Documented in the doc comment rather than implied.Verification
New:
TestThreadsStartPrivate(asserts the channel-not-message path, the private type andinvitable:false),TestThreadsAddMember.