fix: take the guild from the parent category, not from the sole server - #15
Merged
Conversation
CreateUnder/EnsureUnder fell back to Guilds().Sole even though the parent category id already names the server. A bot in several servers could not nest a channel anywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateUnderandEnsureUnderreceive a parent category id — which fully determines the server — and then resolved the guild throughGuilds().Soleanyway. For a bot in more than one server that is an error (bot is in N servers), so nesting a channel under a category was impossible.They now read the guild off the parent (
GET /channels/{parent}), andEnsureUndercreates directly with the id it already has rather than makingCreateUnderlook the parent up a second time. Net call count is unchanged forEnsureUnder(the sole-guild listing it used to make is now the parent fetch) and +1 for a bareCreateUnder.Every other guild-scoped op is untouched: they still take an explicit guild,
WithGuild, or the sole one.Tests: the two
EnsureUndercases now feed the parent's guild, plus a case asserting nothing lists the bot's servers.