feat: WithGlobalCommands registers slash commands app-wide - #14
Merged
Conversation
Commands were always written to one guild, so a bot meant to be installed on several servers could only ever expose them on one — and the guild lookup fails outright past the first server. Global scope skips that lookup entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commandsBasealways resolved a guild, so every command op (Register,List,Create,Edit,Delete,Registry.Sync) targeted exactly one server — and failed outright once the bot was in more than one, since the fallback isGuilds().Sole.WithGlobalCommands()scopes them to the application instead:/applications/{app}/commands. Every server the bot is in gets them, and the guild lookup is skipped, not merely satisfied.Guild scope stays the default — guild commands appear instantly where global ones take up to an hour to propagate, which is what you want while iterating. Nothing else that resolves a guild (channels, members, roles) is affected.
Tests: the default base is still the guild path, the global base is the application path and issues no
/users/@me/guildscall, and the option reaches the client throughNew.