Conversation
Item.itemRegistry is renamed/removed by this modpack's coremods at runtime, so RecipeDumpContext's static initializer threw NoSuchFieldError as soon as a dump started. The exception was silently swallowed by the worker thread's default uncaught exception handler, so the dump looked like it was hanging: file created (0 bytes), one placeholder -1/-1 progress tick, then nothing -- no crash, no log line. - Use the stable public Forge API GameData.getItemRegistry() instead of the raw Item.itemRegistry field. - Log dump failures properly (overall crash + per-item failures) so a single broken recipe handler no longer silently truncates the whole (multi-hour) dump. Built and verified against GT_New_Horizons_2.8.4_Java_17-25 (the exact dependency versions already updated in this fork): CodeChickenCore 1.4.10, NotEnoughItems 2.8.44-GTNH, Hodgepodge 2.6.112, GT5-Unofficial 5.09.51.482. Full 56028-recipe dump now completes normally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.