Repository navigation
fix(dashboard): SSE stall eviction is elapsed-time based; one idempotent teardown for every exit path (Sage review of #664) - #665
Merged
Conversation
…ent teardown for every exit path (Sage review of #664) - Eviction after SSE_MAX_STALLED_MS (30 s) of continuous backpressure measured on a monotonic clock, not 15 ticks: fs.watch debounce bursts during a busy batch could otherwise burn the tick budget in ~3 s and drop a briefly-backpressured healthy client. - teardownSseClient(clients, client): unregister + clear the ping timer (now owned by the client record) + destroy, idempotent. Used by stall eviction, synchronous write failure (previously deleted without destroy/clearInterval, leaving the ping timer retaining the response), ping write failure, socket timeout, and req/res close/error. Tests: bursty-broadcast no-evict, boundary, recovery, throw → full teardown with timer cleared, idempotent teardown, 39-hour scenario. 4143 pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
measured on a monotonic clock, not 15 ticks: fs.watch debounce bursts
during a busy batch could otherwise burn the tick budget in ~3 s and drop
a briefly-backpressured healthy client.
(now owned by the client record) + destroy, idempotent. Used by stall
eviction, synchronous write failure (previously deleted without
destroy/clearInterval, leaving the ping timer retaining the response),
ping write failure, socket timeout, and req/res close/error.
Tests: bursty-broadcast no-evict, boundary, recovery, throw → full teardown
with timer cleared, idempotent teardown, 39-hour scenario. 4143 pass.