Show Car claims on claim card and history (RND-1677) by hugokallstrom · Pull Request #2930 · HedvigInsurance/android

hugokallstrom · 2026-04-23T10:49:22Z

Summary

Add PartnerClaim GraphQL type support and fetch partner claims alongside regular claims
Partner claims appear mixed in the same horizontal pager on the home screen, sorted by submission date
Partner claims appear in claim history list with "Closed" label
New simplified partner claim details screen (status card, display items, T&C documents — no chat/files/audio)
Extract shared composables (DisplayItemsSection, ExplanationBottomSheet, TermsConditionsCard) from feature-claim-details to ui-claim-status for reuse

Context

Backend PR: HedvigInsurance/claims-service#1170
Notion: RND-1677 — Show Car claims on app claim card and history

Test plan

Verify partner claims show up on home screen alongside regular claims
Verify tapping a partner claim card navigates to the simplified details screen
Verify partner claims appear in claim history (Profile → Claim history)
Verify tapping a partner claim in history navigates to the details screen
Verify regular claims still work as before (no regressions)
Verify the details screen shows status card, display items, and T&C document

🤖 Generated with Claude Code

notion-workspace · 2026-04-23T10:49:27Z

🚐 Show Car claims on app claim card and history

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Extends the Home query to include partnerClaimsActive, merges them with regular claims sorted by date, and threads partnerClaimIds through ClaimStatusCardsData so the UI can dispatch to the correct details screen. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Adds onPartnerClaimDetailCardClicked parameter throughout the home composable stack (HomeGraph → HomeDestination → HomeScreen → HomeScreenSuccess), routing partner claim card taps to a separate details screen based on partnerClaimIds from ClaimStatusCardsData. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Extends the claim history screen to include partner claims alongside regular claims, sorted by submission date. Partner claims dispatch to a separate navigation target on click. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Use IconButton with wrapContentSize(CenterEnd) and Column padding, matching the established pattern from the regular claim details screen. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@include

The claims/claimsActive fields are mutually exclusive via @skip/@include directives, but `?:` treats an empty list as non-null, picking it over the populated field. Use `.orEmpty()` concatenation instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…etail Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…rough ViewModel Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…lbacks Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…details Since partner claims and regular claims share the same feature module, there's no need to extract these components to ui-claim-status. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…to reduce diff noise Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

panasetskaya · 2026-05-04T11:40:04Z

     */
    @SerialName("claimId")
    val claimId: String,
+    val isPartnerClaim: Boolean = false,


Could it happen that if we deeplink to here with id for car claim, we'll hit error screen due to this being default false?

Removed this

panasetskaya · 2026-05-04T11:41:59Z

+        ClaimStatus.REOPENED -> ClaimDetailUiState.Content.ClaimStatus.REOPENED
+        ClaimStatus.UNKNOWN__, null -> ClaimDetailUiState.Content.ClaimStatus.UNKNOWN
+      },
+      claimOutcome = ClaimDetailUiState.Content.ClaimOutcome.UNKNOWN,


I remember there being some problems with having the outcome here from the BE, right? So we can't really have status "Paid" and payout can only be mentioned in the details?

no "10000 kr", "Paid" pill on the card, I mean

Correct, we dont get outcome from EIR.

panasetskaya · 2026-05-04T11:44:04Z

+            ClaimHistory(
+              id = history.id,
+              claimType = history.claimType,
+              submittedAt = history.submittedAt?.atStartOfDayIn(TimeZone.UTC) ?: Clock.System.now(),


should it be nullable, the submittedAt?

panasetskaya · 2026-05-04T11:47:57Z

  @Immutable
  data class ClaimStatusCardsData(
    val claimStatusCardsUiState: NonEmptyList<ClaimStatusCardUiState>,
+    val partnerClaimIds: Set<String> = emptySet(),


could we have maybe isPartnerClaim boolean property inside ClaimStatusCardUiState instead of partnerClaimIds here?

panasetskaya

left a couple of comments

- Drop isPartnerClaim from claim detail navigation; use case now queries regular claims first and falls back to partner on NoClaimFound, so deep-linked partner claim IDs no longer hit the error screen. - Make submittedAt/submittedDate nullable through ClaimHistory and ClaimStatusCardUiState; sort with nullsLast and hide the subtitle when the BE does not return a submission date instead of substituting "now". - Drop partnerClaimIds from HomeData since the click handler no longer needs the discriminator. - Show iOS-style copyable Reference number / Email rows on the partner claim detail screen and the partner support paragraph above the details for active partner claims. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…Case Replace the nested while loop and shared mutable flags with a linear flow: first iteration runs the regular endpoint and falls back to partner on NoClaimFound, then a clean polling loop calls whichever endpoint matched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Per Mariia's review: make the partner-vs-regular distinction explicit on the card UI state instead of leaving it implicit in pill types and nullable display fields. No consumer branches on it today, but it makes the model honest about a card knowing what kind of claim it represents. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

This reverts commit a44fe35.

# Conflicts: # app/apollo/apollo-octopus-public/src/commonMain/graphql/com/hedvig/android/apollo/octopus/schema.graphqls # app/core/core-resources/src/androidMain/res/values-sv-rSE/strings.xml # app/core/core-resources/src/androidMain/res/values/strings.xml # app/core/core-resources/src/commonMain/composeResources/values-sv-rSE/strings.xml # app/core/core-resources/src/commonMain/composeResources/values/strings.xml

panasetskaya

Looks great!

hugokallstrom requested a review from a team as a code owner April 23, 2026 10:49

hugokallstrom and others added 15 commits April 23, 2026 12:52

feat: add PartnerClaim type to GraphQL schema

2f6d1d0

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add PartnerClaimFragment GraphQL fragment

c46ab04

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add fromPartnerClaim factory methods for claim card UI state

07a2a6e

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: merge partner claims into claim history

08d0b42

Extends the claim history screen to include partner claims alongside regular claims, sorted by submission date. Partner claims dispatch to a separate navigation target on click. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor: extract shared claim detail composables to ui-claim-status

f5210ee

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add partner claim details module with simplified details screen

7740623

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: wire partner claim details into app navigation and DI

d7cce70

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: right-align arrow icon in partner claim email row

ad5512e

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: match email row styling to chat row pattern in claim details

c43dae0

Use IconButton with wrapContentSize(CenterEnd) and Column padding, matching the established pattern from the regular claim details screen. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: simplify email row to plain clickable card

ad3d88c

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: remove handler email from partner claim details screen

de0f652

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

chore: update GraphQL schema from introspection

7b9621a

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

chore: run ktlint formatting

221c87c

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

hugokallstrom force-pushed the feat/show-car-claims branch from 1982404 to 221c87c Compare April 23, 2026 10:58

hugokallstrom changed the title ~~Show partner car claims (Eir) on home screen and claim history (RND-1677)~~ Show Car claims on claim card and history (RND-1677) Apr 23, 2026

hugokallstrom and others added 11 commits April 23, 2026 14:09

docs: add design spec for unifying partner claim into regular claim d…

a69ea1e

…etail Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

docs: add implementation plan for unifying partner claim detail

4cbe579

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

feat: add isPartnerClaim flag to claim detail destination and wire th…

16e69fb

…rough ViewModel Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add partner claim query support to GetClaimDetailUiStateUseCase

9759d7d

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: hide uploaded files header when no submitted content or files

4e19eea

refactor: unify claim detail navigation — remove partner-specific cal…

2695345

…lbacks Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor: delete feature-partner-claim-details module and all references

75a1517

chore: remove accidentally staged worktree

dffcca6

chore: run ktlint formatting

6bc0a31

fix: use kotlin.time.Clock instead of kotlinx.datetime.Clock

042cabe

hugokallstrom and others added 4 commits April 27, 2026 11:11

fix: show submitted date instead of exposure name on partner claim cards

474926b

chore: remove design spec and implementation plan docs

ed5daf4

chore: restore original function ordering in ClaimDetailsDestination …

3089a81

…to reduce diff noise Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

hugokallstrom marked this pull request as draft April 27, 2026 12:42

hugokallstrom marked this pull request as ready for review April 28, 2026 07:53

panasetskaya reviewed May 4, 2026

View reviewed changes

hugokallstrom and others added 5 commits May 7, 2026 10:15

chore: download strings

cea78ef

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Revert "chore: add isPartnerClaim flag to ClaimStatusCardUiState"

318ca9a

This reverts commit a44fe35.

hugokallstrom requested a review from panasetskaya May 7, 2026 09:02

hugokallstrom enabled auto-merge (squash) May 7, 2026 09:09

panasetskaya approved these changes May 7, 2026

View reviewed changes

hugokallstrom merged commit e7eb78e into develop May 7, 2026
4 checks passed

hugokallstrom deleted the feat/show-car-claims branch May 7, 2026 11:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show Car claims on claim card and history (RND-1677)#2930

Show Car claims on claim card and history (RND-1677)#2930
hugokallstrom merged 36 commits intodevelopfrom
feat/show-car-claims

hugokallstrom commented Apr 23, 2026

Uh oh!

notion-workspace Bot commented Apr 23, 2026

Uh oh!

panasetskaya May 4, 2026

Uh oh!

hugokallstrom May 7, 2026

Uh oh!

panasetskaya May 4, 2026 •

edited

Loading

Uh oh!

panasetskaya May 4, 2026

Uh oh!

hugokallstrom May 7, 2026

Uh oh!

panasetskaya May 4, 2026

Uh oh!

hugokallstrom May 7, 2026

Uh oh!

panasetskaya May 4, 2026

Uh oh!

hugokallstrom May 7, 2026

Uh oh!

panasetskaya left a comment

Uh oh!

panasetskaya left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

hugokallstrom commented Apr 23, 2026

Summary

Context

Test plan

Uh oh!

notion-workspace Bot commented Apr 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

panasetskaya May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

panasetskaya left a comment

Choose a reason for hiding this comment

Uh oh!

panasetskaya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

panasetskaya May 4, 2026 •

edited

Loading