Skip to content

fix: use ffprobe_path() instead of hardcoded /usr/bin/ffprobe in test_video.py #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kstonekuan merged 1 commit into from
Aug 23, 2026
Merged

fix: use ffprobe_path() instead of hardcoded /usr/bin/ffprobe in test_video.py #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions tests/test_video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import pytest

from hflow.ffmpeg import ffmpeg_path
from hflow.ffmpeg import ffmpeg_path, ffprobe_path
from hflow.video import (
AccessUnit,
VideoEncodeError,
Expand Down Expand Up @@ -151,9 +151,7 @@ def test_png_input_codec_upholds_guarantees(tmp_path: Path) -> None:

def _ffprobe_video_stream_fields(mp4_path: Path) -> dict[str, str]:
"""Read codec/profile/decoded-frame-count fields from the first video stream."""
ffprobe_binary = ffmpeg_path().with_name("ffprobe")
if not ffprobe_binary.is_file():
ffprobe_binary = Path("/usr/bin/ffprobe")
ffprobe_binary = ffprobe_path()
completed = subprocess.run(
[
str(ffprobe_binary),
Expand Down