Open
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts SonarCloud configuration to explicitly define source and test directories and to remove coverage exclusions for test files, ensuring tests are analyzed and included in coverage metrics. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- By removing
sonar.python.coverage.exclusions=tests/**/*.py, Sonar will now include test files in coverage calculations, which is unusual; if that’s not intended, consider restoring or refining the exclusions pattern. - Confirm that
src/andtests/are the correct relative paths from the project root for Sonar (and that they are not already configured elsewhere), since misaligned paths here will cause Sonar to miss code or tests entirely.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- By removing `sonar.python.coverage.exclusions=tests/**/*.py`, Sonar will now include test files in coverage calculations, which is unusual; if that’s not intended, consider restoring or refining the exclusions pattern.
- Confirm that `src/` and `tests/` are the correct relative paths from the project root for Sonar (and that they are not already configured elsewhere), since misaligned paths here will cause Sonar to miss code or tests entirely.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Implements changes in SonarQube Cloud settings
Implements Dependabot changes
Fixes maintainability issues
Summary by Sourcery
CI: