Skip to content

fix(ci): changes sonarcloud coverage settings#88

Open
agjharms wants to merge 9 commits intomainfrom
fix/sonarcloud_coverage
Open

fix(ci): changes sonarcloud coverage settings#88
agjharms wants to merge 9 commits intomainfrom
fix/sonarcloud_coverage

Conversation

@agjharms
Copy link
Copy Markdown
Contributor

@agjharms agjharms commented Mar 24, 2026

Implements changes in SonarQube Cloud settings
Implements Dependabot changes
Fixes maintainability issues

Summary by Sourcery

CI:

  • Update SonarCloud properties to set source and test paths and remove explicit coverage exclusions for test files.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 24, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts SonarCloud configuration to explicitly define source and test directories and to remove coverage exclusions for test files, ensuring tests are analyzed and included in coverage metrics.

File-Level Changes

Change Details Files
Configure SonarCloud to explicitly use src/ as sources and tests/ as test directory.
  • Add sonar.sources pointing to src/ directory.
  • Add sonar.tests pointing to tests/ directory.
sonar-project.properties
Ensure test files are included in Python coverage analysis on SonarCloud.
  • Remove coverage exclusion pattern that previously excluded all test Python files from coverage metrics.
sonar-project.properties

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • By removing sonar.python.coverage.exclusions=tests/**/*.py, Sonar will now include test files in coverage calculations, which is unusual; if that’s not intended, consider restoring or refining the exclusions pattern.
  • Confirm that src/ and tests/ are the correct relative paths from the project root for Sonar (and that they are not already configured elsewhere), since misaligned paths here will cause Sonar to miss code or tests entirely.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- By removing `sonar.python.coverage.exclusions=tests/**/*.py`, Sonar will now include test files in coverage calculations, which is unusual; if that’s not intended, consider restoring or refining the exclusions pattern.
- Confirm that `src/` and `tests/` are the correct relative paths from the project root for Sonar (and that they are not already configured elsewhere), since misaligned paths here will cause Sonar to miss code or tests entirely.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant