Add Firefox support for CharacterSync extension#325
Open
HarmlessHarm wants to merge 1 commit intodevelopfrom
Open
Add Firefox support for CharacterSync extension#325HarmlessHarm wants to merge 1 commit intodevelopfrom
HarmlessHarm wants to merge 1 commit intodevelopfrom
Conversation
Firefox does not support externally_connectable / chrome.runtime.sendMessage for external messaging. The Firefox build of CharacterSync injects a bridge content script that relays messages via window.postMessage. This extracts a shared sendExtensionMessage() helper that detects Firefox and uses the postMessage bridge, keeping the Chrome path unchanged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
HarmlessHarm
force-pushed
the
feature/firefox-extension-support
branch
from
e103de9 to
2d60432
Compare
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| window.removeEventListener("message", handler); | ||
| resolve(event.data); | ||
| } | ||
| window.addEventListener("message", handler); |
Check failure
Code scanning / SonarCloud
Origins should be verified during cross-origin communications High
| resolve(event.data); | ||
| } | ||
| window.addEventListener("message", handler); | ||
| window.postMessage({ CS_BRIDGE: true, requestId, request_content }, "*"); |
Check failure
Code scanning / SonarCloud
Origins should be verified during cross-origin communications High
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendExtensionMessage()helper ingeneralFunctions.jsthat detects Firefox via user agentwindow.postMessagewith the CS_BRIDGE protocol to communicate with the CharacterSync extension's bridge content scriptchrome.runtime.sendMessageunchangedextensionInstalled(),getCharacterSyncStorage(), andgetCharacterSyncCharacter()to use the shared helperTest plan