sec: add gitleaks CI job scanning full commit history - #331
Open
raaidrushdy wants to merge 3 commits into
Open
Conversation
Contributor
Preview EnvironmentA preview environment can be spun up on demand for this PR.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8efb612c71
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a CI job that scans the full commit history for secrets using gitleaks on every push/PR to main and staging, plus a weekly scheduled run. Closes the gap identified in the baseline audit (PR #329): pre-commit's detect-secrets only scans staged diffs, so anything already merged into history is invisible to current tooling.
Type of Change
Affected Components
/.github/workflowsMotivation
Covers Planner task 26T2-DEV-RR-003. The baseline audit's manual gitleaks scan found 31 historical findings, including a live GCP service account private key. This automates that check going forward so future exposures are caught on the next push instead of requiring another manual audit to surface them.
Testing Done
Security Considerations
This job will flag known historical findings (the rotated Fernet key, the GCP key commit) on first run, expected, and confirms the job works correctly rather than indicating a new problem.
gitleaks/gitleaks-actionis pinned to a commit SHA (e0c47f4, v3.0.0), not a version tag.Breaking Changes
Rollback Plan
Checklist