Fix compiling for linux arm64#650
Conversation
283c6ee to
2cb6709
Compare
|
Why this pr have been close ? |
Did you want it reopened? It's been a few months with no comments or reviews. |
|
Forget to review and don't have much time to work on spaghettikart in general. Don't hesitate to ping me on discord if you don't see any review. Will do a review now |
It's gone under my radar as well, no worries. I'll reopen and do a rebase sometime soon. Figured in the months since that some of these might have already been fixed or changed. |
|
Rebased 8 commits, resolving CMakeLists.txt conflicts (indentation churn from #680 "Fix Windows Build" + removed a find_package(OpenGL) block upstream had reintroduced). Dropped both Removed the redundant Fixed broken text substitution in the "Use memset over deprecated bzero" commit: the original commit blindly replaced bzero -> memset in include/stubs.h and src/os/bstring.h, producing invalid C:
Since no callers use bzero anymore, I just removed the now-unused shim/declaration in both files instead. This still has a runtime crash on linux arm64 since Kenix3/libultraship#1004 didn't land. I'll see what I can find out for it, if there's a solution without modifying LUS at all. |
This pull request contains several changes.
BUILD_MK64with the externally compiled torch, which would cause torch to throw an error on trying to makemk64.o2r. This definition has been added.ALIGNED16andALIGNED8were empty. I added the alignment to the macros so they do something, and I addedALIGNED4096so the 256MB allocation is set at the start of the virtual memory page.ALIGNED16macro to the memory pool in memory.cUSE_OPENGLESdefineAn opt-in for segmented addresses is missing somewhere, see: Kenix3/libultraship#1004